GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43888: Remove coverage builds from CI by ammaraskar · Pull Request #25679 · python/cpython

Conversation

@ammaraskar

@ammaraskar ammaraskar commented Apr 28, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We introduced code coverage a while ago as part of https://bugs.python.org/issue23721 and python/core-workflow#2 but it looks like this feature isn't really utilized by many people based on searching for "codecov" on github and bpo. These builds take way longer due to the instrumentation and this is cutting into valuable CI time. The builds are now also failing on master with the new timeout mechanism.

Let's just get rid of the coverage builds and see if anyone complains :)

https://bugs.python.org/issue43888

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ned-deily and brandtbucher reacted with thumbs up emoji RodrigoDornelles reacted with thumbs down emoji
All reactions
  • 👍 2 reactions
  • 👎 1 reaction
@ammaraskar
bpo-43888: Remove coverage builds from CI
10928d2
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 28, 2021
@bedevere-bot bedevere-bot added the awaiting review label Apr 28, 2021
@ammaraskar ammaraskar added skip news and removed awaiting review labels Apr 28, 2021
@ammaraskar
ammaraskar requested a review from brettcannon April 28, 2021 05:10
brettcannon
brettcannon approved these changes Apr 29, 2021
View reviewed changes
@bedevere-bot bedevere-bot added the awaiting merge label Apr 29, 2021
@brettcannon

brettcannon commented Apr 29, 2021

Copy link
Copy Markdown
Member

Before this can be merged there are probably some changes required over on the devguide to go with this.

@ammaraskar are you up to do a PR for that? We should probably drop the devguide mentions before we actually drop things.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ammaraskar

ammaraskar commented Apr 29, 2021

Copy link
Copy Markdown
Member Author

Sounds good, let me check up on what changes need to be made in the devguide.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Apr 30, 2021

Copy link
Copy Markdown
Member

I never used this feature.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ammaraskar ammaraskar mentioned this pull request Apr 30, 2021
Remove mention of old coverage comment from checklist python/devguide#685
Merged
@ammaraskar

ammaraskar commented Apr 30, 2021

Copy link
Copy Markdown
Member Author

Brett, the only mention I found in the devguide about coverage that seemed relevant to codecov was in the committing checklist, I made a PR for that here: python/devguide#685

The rest is a guide on how to determine coverage locally which should stay in the devguide.
brettcannon reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta

Mariatta commented Apr 30, 2021

Copy link
Copy Markdown
Member

DevGuide PR has been merged. Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon
brettcannon merged commit 726c931 into python:master Apr 30, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 30, 2021
@brettcannon

brettcannon commented Apr 30, 2021

Copy link
Copy Markdown
Member

@ammaraskar thanks for the PRs!

@Mariatta thanks for merging the devguide PR!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RodrigoDornelles

RodrigoDornelles commented May 7, 2021

Copy link
Copy Markdown

I missed it the same day, but now I had time to mention it, I usually check the coverage status to analyze and study more about construct languages.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nightlark nightlark mentioned this pull request Aug 21, 2021
Disallow failure of the coverage build in Travis? python/core-workflow#101
Closed
@ammaraskar ammaraskar mentioned this pull request Oct 6, 2021
bpo-40237: Fix the coverage gate in travis CI #19460
Closed
@hugovk hugovk mentioned this pull request Jun 23, 2023
Consider testing zoneinfo with tzdata PyPI package installed #99649
Closed
@hugovk hugovk mentioned this pull request Oct 2, 2023
Remove unused Misc/requirements-test.txt #110240
Merged
@hugovk

hugovk commented Oct 2, 2023

Copy link
Copy Markdown
Member

This missed Misc/requirements-test.txt, please see #110240 to remove it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Feb 24, 2024
Use the codecov GH Action #83958
Closed
Add c code coverage to codecov #73733
Closed
@hugovk hugovk mentioned this pull request Feb 21, 2026
Remove unused size.py and refs to removed CPython files python/release-tools#343
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@ammaraskar @brettcannon @vstinner @Mariatta @RodrigoDornelles @hugovk @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.