Description

assignee = 'https://github.com/tiran'
closed_at = None
created_at = <Date 2021-08-11.11:35:40.075>
labels = ['expert-SSL']
title = 'ssl.OP_LEGACY_SERVER_CONNECT missing'
updated_at = <Date 2021-08-16.03:58:50.811>
user = 'https://github.com/xtkoba'

activity = <Date 2021-08-16.03:58:50.811>
actor = 'python-dev'
assignee = 'christian.heimes'
closed = False
closed_date = None
closer = None
components = ['SSL']
creation = <Date 2021-08-11.11:35:40.075>
creator = 'xtkoba'
dependencies = []
files = []
hgrepos = []
issue_num = 44888
keywords = ['patch']
message_count = 1.0
messages = ['399386']
nosy_count = 3.0
nosy_names = ['christian.heimes', 'python-dev', 'xtkoba']
pr_nums = ['27776']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue44888'
versions = []

Activity

1. xtkoba commented on Aug 11, 2021

   

   xtkobamannequin

   on Aug 11, 2021

   MannequinAuthor

   More actions

   Please implement ssl.OP_LEGACY_SERVER_CONNECT constant that corresponds to SSL_OP_LEGACY_SERVER_CONNECT in C. This is required to make OpenSSL 3.0.0 behave like 1.1.1.

   Reacted by Richard Green, Vladimir remar, John, Rachel Tan, Kodiak and Mohamed H. Oreaba
2. xtkoba

   assigned

   tiran

   on Aug 11, 2021
3. xtkoba

   added

   topic-SSL

   on Aug 11, 2021
4. xtkoba

   assigned

   tiran

   on Aug 11, 2021
5. xtkoba

   added

   topic-SSL

   on Aug 11, 2021
6. ezio-melotti

   transferred this issue fromon Apr 10, 2022
7. ezio-melotti

   added this to OpenSSL 3on Jun 15, 2022
8. ezio-melotti

   moved this to Todo in OpenSSL 3on Jun 15, 2022
9. tiran

   added

   3.11only security fixesonly security fixes

   3.10 (EOL)end of lifeend of life

   3.12only security fixesonly security fixes

   on Aug 3, 2022
10. tiran commented on Aug 3, 2022

    

    tiran

    on Aug 3, 2022

    Member

    More actions

    @graingert Do you want to backport the change to 3.11 and 3.10?
11. graingert commented on Aug 3, 2022

    

    graingert

    on Aug 3, 2022

    Contributor

    More actions

    @graingert Do you want to backport the change to 3.11 and 3.10?

    I'd like the backport in 3.10 and I hope the patch will apply automatically
12. 3 remaining items

13. graingert commented on Aug 3, 2022

    

    graingert

    on Aug 3, 2022

    Contributor

    More actions

    Hmm but then users reading the 3.11 docs will see the wrong versionadded

    cc @hugovk
14. hugovk commented on Aug 3, 2022

    

    hugovk

    on Aug 3, 2022

    Member

    More actions

    So was it added in 3.11 and backported to 3.10.6?

    Can it be .. versionadded:: 3.10.6 for both?

    Otherwise, https://devguide.python.org/documentation/markup/?highlight=versionadded#paragraph-level-markup says of versionadded:

    The first argument must be given and is the version in question. The second argument is optional and can be used to describe the details of the feature.

    For example:

    • .. versionadded:: 3.9 backported to 3.7 and 3.8.
      https://docs.python.org/3/library/decimal.html#decimal.HAVE_CONTEXTVAR
    • .. versionadded:: 3.9 (the field exists since 3.8 but it's only used since 3.9)
      https://docs.python.org/3/c-api/typeobj.html#c.PyTypeObject.tp_vectorcall
15. hugovk

    closed this as completedin #93927on Dec 20, 2022
16. Repository owner moved this from Todo to Done in OpenSSL 3on Dec 20, 2022
17. hugovk

    added a commit that references this issue on Dec 20, 2022

    gh-89051: Add ssl.OP_LEGACY_SERVER_CONNECT (#93927)

    79ccc03
18. hugovk commented on Dec 20, 2022

    

    hugovk

    on Dec 20, 2022

    Member

    More actions

    I've merged #93927 with:

    • .. versionadded:: 3.12 in 3.12/main

    And let's go for:

    • .. versionadded:: 3.10.10 in 3.10
    • .. versionadded:: 3.11.2 in 3.11

    @graingert Please could you make the 3.10 and 3.11 backport PRs?
19. hugovk

    reopened this on Dec 20, 2022
20. hugovk commented on Dec 20, 2022

    

    hugovk

    on Dec 20, 2022

    Member

    More actions

    Actually, let's try using Miss Islington and then modify those PRs.
21. hugovk

    added a commit that references this issue on Dec 20, 2022

    pythongh-89051: Add ssl.OP_LEGACY_SERVER_CONNECT (python#93927)

    dd21351
22. hugovk commented on Dec 20, 2022

    

    hugovk

    on Dec 20, 2022

    Member

    More actions

    Miss Islington didn't like the merge conflicts, back to the command line. Please see PRs #100359 and #100360.
23. jonburdo

    added a commit that references this issue on Dec 20, 2022

    pythongh-89051: Add ssl.OP_LEGACY_SERVER_CONNECT (python#93927)

    33ba6a5
24. hugovk commented on Dec 21, 2022

    

    hugovk

    on Dec 21, 2022

    Member

    More actions

    I closed the backports, as we don't normally backport new features to bugfix branches.

    https://devguide.python.org/versions/

    This will be in the next 3.12.0 alpha 4, due on 2023-01-09.
25. hugovk

    closed this as completedon Dec 21, 2022
26. iritkatriel

    added a commit that references this issue on Dec 28, 2022

    Merged main into regmachine branch (#50)

    fdc73cb
27. jessecomeau87

    added a commit that references this issue on May 20, 2024

    gh-89051: Add ssl.OP_LEGACY_SERVER_CONNECT (#93927)

    8076cc3

Issue actions