GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-90690: Remove `PRECALL` instruction by markshannon · Pull Request #92925 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented May 18, 2022

Copy link
Copy Markdown
Member

The PRECALL instruction exists only to assist in specializing bound-methods and calls to Python classes.

We can get almost all the benefit ofr bound-methods by adding another specialization of CALL, and it looks like the best approach to specialize calls to Python classes is push a shim frame.

So, it makes sense to remove the PRECALL instruction.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
markshannon added 2 commits May 18, 2022 12:51
@markshannon
Remove PRECALL instruction.
8d937ef
@markshannon
Add news and remove PRECALL from docs.
bad98cf
@bedevere-bot bedevere-bot added the awaiting core review label May 18, 2022
@markshannon

markshannon commented May 18, 2022

Copy link
Copy Markdown
Member Author

About 1% faster
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
markshannon requested a review from Fidget-Spinner May 18, 2022 13:37
@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 18, 2022
@bedevere-bot

bedevere-bot commented May 18, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit bad98cf 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 18, 2022
Fidget-Spinner
Fidget-Spinner approved these changes May 19, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 19, 2022
@markshannon
markshannon merged commit e48ac9c into python:main May 19, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 19, 2022
@tonybaloney tonybaloney mentioned this pull request Apr 26, 2023
GH-90690: Mention removal of PRECALL in What's New #103910
Merged
@markshannon
markshannon deleted the remove-precall branch September 26, 2023 12:49
@tecknicaltom tecknicaltom mentioned this pull request May 28, 2024
Fail to install on Ubuntu 24.04 google/atheris#82
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @bedevere-bot @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.