GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-90690: Mention removal of ``PRECALL`` in What's New by tonybaloney · Pull Request #103910 · python/cpython

Conversation

@tonybaloney

@tonybaloney tonybaloney commented Apr 26, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The removal of PRECALL is missing from the release notes.

#92925

  • Issue: Improve efficiency of PRECALL/CALL instructions #90690

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tonybaloney
Update what's new in 3.12 notes
b19d090 
The removal of PRECALL is missing from the release notes
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 26, 2023
@tonybaloney
Remove trailing whitespace
020d924
AA-Turner
AA-Turner approved these changes Apr 27, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Apr 27, 2023
@AA-Turner
AA-Turner requested a review from markshannon April 27, 2023 00:42
@AA-Turner AA-Turner changed the title Update what's new in 3.12 notes GH-90690: Mention removal of PRECALL in What's New Apr 27, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 27, 2023
Improve efficiency of PRECALL/CALL instructions #90690
Closed
@AA-Turner AA-Turner changed the title GH-90690: Mention removal of PRECALL in What's New GH-90690: Mention removal of PRECALL in What's New Apr 27, 2023
AA-Turner
AA-Turner reviewed Apr 27, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tonybaloney @AA-Turner
Update Doc/whatsnew/3.12.rst
d0daf1c 
Co-authored-by: Adam Turner <[email protected]>
@AA-Turner AA-Turner added the 3.12 only security fixes label Apr 27, 2023
AA-Turner
AA-Turner reviewed Apr 27, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Fix cross-referencing
83a583d
@AA-Turner
AA-Turner self-requested a review April 27, 2023 00:48
AA-Turner
AA-Turner approved these changes Apr 27, 2023
View reviewed changes
@JelleZijlstra

JelleZijlstra commented Apr 27, 2023

Copy link
Copy Markdown
Member

There are also numerous new opcodes that are not mentioned here. Perhaps we should make a table similar to the one in https://docs.python.org/3.12/whatsnew/3.11.html#cpython-bytecode-changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
furkanonder
furkanonder approved these changes May 8, 2023
View reviewed changes
@hugovk
Merge branch 'main' into patch-2
e04b587
hugovk
hugovk approved these changes Sep 6, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Conflict resolved.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 6, 2023
@hugovk hugovk added the needs backport to 3.12 only security fixes label Sep 6, 2023
@hugovk

hugovk commented Sep 6, 2023

Copy link
Copy Markdown
Member

Some opcode additions have since been documented. Let's merge this, and further improvements welcome.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk enabled auto-merge (squash) September 6, 2023 20:19
@hugovk
hugovk merged commit f9bd6e4 into python:main Sep 6, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 6, 2023
@miss-islington

miss-islington commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

Thanks @tonybaloney for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 6, 2023
@tonybaloney @AA-Turner
@hugovk @miss-islington
pythonGH-90690: Mention removal of PRECALL in What's New (pythonG…
12bb8ec 
…H-103910)

(cherry picked from commit f9bd6e4)

Co-authored-by: Anthony Shaw <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 6, 2023

Copy link
Copy Markdown

GH-109027 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Sep 6, 2023
Yhg1s pushed a commit that referenced this pull request Sep 8, 2023
@miss-islington @tonybaloney
@AA-Turner @hugovk
[3.12] GH-90690: Mention removal of PRECALL in What's New (GH-103910
19d8226 
) (#109027)

GH-90690: Mention removal of ``PRECALL`` in What's New (GH-103910)
(cherry picked from commit f9bd6e4)

Co-authored-by: Anthony Shaw <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes
@furkanonder furkanonder furkanonder approved these changes
@markshannon markshannon Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.12 only security fixes docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@tonybaloney @JelleZijlstra @hugovk @miss-islington @bedevere-bot @AA-Turner @furkanonder
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.