Description

kumaraditya303

opened on May 25, 2022

Issue body actions

CPython checks for stdarg.h as HAVE_STDARG_PROTOTYPES ¹ at some places ² but not at other places ³. Either this check should be repeated at every call site or should be removed all together, most compilers supports this nowadays (should be verified with buildbots).

cc @vstinner @tiran @erlend-aasland

Footnotes

1. https://github.com/python/cpython/blob/16a7e4a0b75080275bf12cfb71d54b01d85099b2/configure.ac#L5026 ↩

2. https://github.com/python/cpython/blob/16a7e4a0b75080275bf12cfb71d54b01d85099b2/Modules/_asynciomodule.c#L2646 ↩

3. https://github.com/python/cpython/blob/16a7e4a0b75080275bf12cfb71d54b01d85099b2/Objects/call.c#L557 ↩

Activity

1. kumaraditya303

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on May 25, 2022
2. erlend-aasland

   added

   buildThe build process and cross-buildThe build process and cross-build

   on May 25, 2022
3. vstinner commented on May 25, 2022

   

   vstinner

   on May 25, 2022

   Member

   More actions

   Do you want to propose a PR for that?
4. kumaraditya303

   self-assigned this

   on May 25, 2022
5. kumaraditya303

   added

   3.12only security fixesonly security fixes

   on May 25, 2022
6. kumaraditya303 commented on May 25, 2022

   

   kumaraditya303

   on May 25, 2022

   ContributorAuthor

   More actions

   Created PR #93215
7. kumaraditya303

   added a commit that references this issue on May 27, 2022

   Merge branch 'main' of https://github.com/python/cpython into pythong…

   f0ef047
8. vstinner

   closed this as completedin #93215on May 27, 2022
9. vstinner

   added a commit that references this issue on May 27, 2022

   GH-93207: Remove HAVE_STDARG_PROTOTYPES configure check for stdarg.h (#…

   cb04a09
10. erlend-aasland commented on Jun 2, 2022

    

    erlend-aasland

    on Jun 2, 2022

    Contributor

    More actions

    [...] most compilers supports this nowadays

    As pointed out in cython/cython#4820, this may change in the future:

    https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2975.pdf
11. h-vetinari commented on Nov 7, 2022

    

    h-vetinari

    on Nov 7, 2022

    Contributor

    More actions

    As pointed out in cython/cython#4820, this may change in the future:

    https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2975.pdf

    Bit late, but JFYI, this paper got accepted into C23.

    Edit: sorry for the double-post; GH bugging with server errors here...
12. arkamar

    added a commit that references this issue on May 29, 2023

    Fix for Python 3.12 support

    81727b5

Issue actions