GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove redundant fields from basicblock: b_nofallthrough, b_exit, b_return · Issue #93444 · python/cpython

Remove redundant fields from basicblock: b_nofallthrough, b_exit, b_return #93444

New issue
Copy link
New issue
Copy link
Closed
#93445
Closed
Remove redundant fields from basicblock: b_nofallthrough, b_exit, b_return#93444
#93445
Copy link
Assignees
iritkatriel
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

Description

@iritkatriel
iritkatriel
opened on Jun 2, 2022
Issue body actions

The fields b_nofallthrough, b_exit, b_return in the compiler's basicblock can be easily calculated form the opcode of the last instruction in the block, so we can remove them.

This change is in line with our general move to simplify the compiler front end by not making it calculate things that the backend can deduce. It increases safety because the cached values need to be kept correct through transformations/optimisations of the block, and this adds opportunities for bugs.

Activity

  1. iritkatriel
    added
    interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)
    on Jun 2, 2022
  2. iritkatriel
    self-assigned this
    on Jun 2, 2022
  3. iritkatriel
    added a commit that references this issue on Jun 2, 2022

    pythongh-93444: remove redundant fields from basicblock: b_nofallthro…

    a17507a
  4. iritkatriel
    closed this as completedin #93445on Jun 3, 2022
  5. iritkatriel
    added a commit that references this issue on Jun 3, 2022

    GH-93444: remove redundant fields from basicblock: b_nofallthrough, b…

    1713ff0
  6. serhiy-storchaka
    added a commit that references this issue on Jun 26, 2022

    Revert 30935 defer bpo45162 to 312 (#94285)

    1ffde3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

  • @iritkatriel
    iritkatriel

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    You are visitor 01402503 — GeezerVison does not store the pages you look up.
    Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.