Description

erlend-aasland

opened on Jun 10, 2022

Issue body actions

"Python build finished successfully!" is only printed if there were missing modules:

cpython/setup.py

Lines 539 to 547 in cf730b5

	if self.missing:
	print()
	print("Python build finished successfully!")
	print("The necessary bits to build these optional modules were not "
	"found:")
	print_three_column(self.missing)
	print("To find the necessary bits, look in setup.py in"
	" detect_modules() for the module's name.")
	print()

Either we print it every time the build succeeds:

diff --git a/setup.py b/setup.py
index 4c497346e8..e87da57a47 100644
--- a/setup.py
+++ b/setup.py
@@ -538,5 +538,9 @@ def print_three_column(lst):
 
-        if self.missing:
+        if not self.failed:
             print()
             print("Python build finished successfully!")
+            print()
+
+        if self.missing:
+            print()
             print("The necessary bits to build these optional modules were not "

Or we just remove that line from setup.py.

I'm fine with either.

Originally reported by @izumiberat in #93659 (comment)

Activity

1. erlend-aasland commented on Jun 10, 2022

   

   erlend-aasland

   on Jun 10, 2022

   ContributorAuthor

   More actions

   cc. @tiran
2. erlend-aasland commented on Jun 10, 2022

   

   erlend-aasland

   on Jun 10, 2022

   ContributorAuthor

   More actions

   Come to think of it, we might want to adjust the "To find the necessary bits, look in setup.py in detect_modules() for the module's name." also.
3. erlend-aasland

   added a commit that references this issue on Jun 10, 2022

   pythongh-93692: setup.py now reports successful builds if the build s…

   d9303c4
4. AA-Turner

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   buildThe build process and cross-buildThe build process and cross-build

   3.12only security fixesonly security fixes

   on Jun 10, 2022
5. erlend-aasland

   closed this as completedin #93693on Jun 24, 2022
6. erlend-aasland

   added a commit that references this issue on Jun 24, 2022

   gh-93692: remove "build finished successfully" message from setup.py (#…

   ab077d1
7. miss-islington

   added 4 commits that reference this issue on Jun 24, 2022

   pythongh-93692: remove "build finished successfully" message from set…

   17354a7

   pythongh-93692: remove "build finished successfully" message from set…

   7b7a520

   gh-93692: remove "build finished successfully" message from setup.py (G…

   e4d72d1

   gh-93692: remove "build finished successfully" message from setup.py (G…

   92d32b9
8. serhiy-storchaka

   added a commit that references this issue on Jun 26, 2022

   Revert 30935 defer bpo45162 to 312 (#94285)

   1ffde3e

Issue actions