Description

erlend-aasland

opened on Jun 14, 2022

Issue body actions

Current code:

cpython/Lib/test/test_sqlite3/test_transactions.py

Lines 28 to 54 in 5bcf33d

	def get_db_path():
	return "sqlite_testdb"
	class TransactionTests(unittest.TestCase):
	def setUp(self):
	try:
	os.remove(get_db_path())
	except OSError:
	pass
	self.con1 = sqlite.connect(get_db_path(), timeout=0.1)
	self.cur1 = self.con1.cursor()
	self.con2 = sqlite.connect(get_db_path(), timeout=0.1)
	self.cur2 = self.con2.cursor()
	def tearDown(self):
	self.cur1.close()
	self.con1.close()
	self.cur2.close()
	self.con2.close()
	try:
	os.unlink(get_db_path())
	except OSError:
	pass

Suggesting to use the test.support helpers TESTFN and unlink.

Activity

1. erlend-aasland

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   testsTests in the Lib/test dirTests in the Lib/test dir

   topic-sqlite3

   on Jun 14, 2022
2. erlend-aasland

   self-assigned this

   on Jun 14, 2022
3. erlend-aasland

   added this to sqlite3 issueson Jun 14, 2022
4. erlend-aasland

   moved this to In Progress in sqlite3 issueson Jun 14, 2022
5. erlend-aasland commented on Jun 14, 2022

   

   erlend-aasland

   on Jun 14, 2022

   ContributorAuthor

   More actions

   We can also swap the timeout with one of the timeout constants in test.support.
6. erlend-aasland

   added a commit that references this issue on Jun 14, 2022

   pythongh-93795: Use test.support TESTFN/unlink in sqlite3 tests

   48873b1
7. erlend-aasland

   linked a pull request that will close this issuegh-93795: Use test.support TESTFN/unlink in sqlite3 tests #93796on Jun 14, 2022
8. erlend-aasland

   closed this as completedin #93796on Jun 14, 2022
9. Repository owner moved this from In Progress to Done in sqlite3 issueson Jun 14, 2022
10. erlend-aasland

    added 5 commits that reference this issue on Jun 14, 2022

    gh-93795: Use test.support TESTFN/unlink in sqlite3 tests (#93796)

    d773c6e

    [3.11] pythongh-93795: Use test.support TESTFN/unlink in sqlite3 tests (

    0d9b1c1

    [3.10] pythongh-93795: Use test.support TESTFN/unlink in sqlite3 tests (

    de0bc5a

    [3.11] gh-93795: Use test.support TESTFN/unlink in sqlite3 tests (GH-…

    7aa4038

    [3.10] gh-93795: Use test.support TESTFN/unlink in sqlite3 tests (GH-…

    8b36ce6
11. serhiy-storchaka

    added a commit that references this issue on Jun 26, 2022

    Revert 30935 defer bpo45162 to 312 (#94285)

    1ffde3e

Issue actions