Description

erlend-aasland

opened on Jun 15, 2022

Issue body actions

cpython/Modules/_sqlite/microprotocols.c

Lines 83 to 87 in 274769c

	/* look for an adapter in the registry */
	key = Py_BuildValue("(OO)", (PyObject*)Py_TYPE(obj), proto);
	if (!key) {
	return NULL;
	}

Can use faster PyTuple_Pack.

cpython/Modules/_sqlite/microprotocols.c

Lines 60 to 63 in 274769c

	key = Py_BuildValue("(OO)", (PyObject*)type, proto);
	if (!key) {
	return -1;
	}

Can use faster PyTuple_Pack.

cpython/Modules/_sqlite/connection.c

Lines 1585 to 1587 in 274769c

	} else {
	return Py_BuildValue("i", sqlite3_total_changes(self->db));
	}

Can use PyLong_FromLong.

Activity

1. erlend-aasland

   linked a pull request that will close this issuegh-93829: In sqlite3, replace Py_BuildValue with faster APIs #93830on Jun 15, 2022
2. erlend-aasland

   added a commit that references this issue on Jun 15, 2022

   pythongh-93829: In sqlite3, replace Py_BuildValue with faster APIs

   bf38cec
3. erlend-aasland

   closed this as completedin #93830on Jun 15, 2022
4. erlend-aasland

   added a commit that references this issue on Jun 15, 2022

   gh-93829: In sqlite3, replace Py_BuildValue with faster APIs (#93830)

   4e9fa71
5. serhiy-storchaka

   added a commit that references this issue on Jun 26, 2022

   Revert 30935 defer bpo45162 to 312 (#94285)

   1ffde3e

Issue actions