Description

tiran

opened on Jun 24, 2022

Issue body actions

Bug report

Some test_importlib cases for extension modules are failing when Python is compiled with dynamic extension support but _testcapi or _testmultiphase are builtin modules:

======================================================================
FAIL: test_module (test.test_importlib.extension.test_finder.Frozen_FinderTests.test_module)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/python-wasm/cpython/Lib/test/test_importlib/extension/test_finder.py", line 25, in test_module
    self.assertTrue(self.find_spec(util.EXTENSIONS.name))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: None is not true

The tests should be skipped if the module name is in sys.builtin_module_names.

Activity

1. tiran

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   3.11only security fixesonly security fixes

   3.12only security fixesonly security fixes

   on Jun 24, 2022
2. tiran

   assigned

   brettcannon

   on Jun 24, 2022
3. tiran

   added a commit that references this issue on Jun 24, 2022

   pythongh-94217: Skip import tests when _testcapi is a builtin

   e90cd8c
4. AlexWaygood

   added

   topic-importlib

   on Jun 24, 2022
5. tiran commented on Jun 24, 2022

   

   tiran

   on Jun 24, 2022

   MemberAuthor

   More actions

   https://buildbot.python.org/all/#/builders/1056/builds/1/steps/10/logs/stdio
6. brettcannon

   linked a pull request that will close this issuegh-94217: Skip import tests when _testcapi is a builtin #94218on Jun 24, 2022
7. miss-islington

   closed this as completedin #94218on Jun 24, 2022
8. miss-islington

   added 3 commits that reference this issue on Jun 24, 2022

   gh-94217: Skip import tests when _testcapi is a builtin (GH-94218)

   0a40025

   pythongh-94217: Skip import tests when _testcapi is a builtin (python…

   315d183

   gh-94217: Skip import tests when _testcapi is a builtin (GH-94218)

   89ba660
9. serhiy-storchaka

   added a commit that references this issue on Jun 26, 2022

   Revert 30935 defer bpo45162 to 312 (#94285)

   1ffde3e

Issue actions