Description

pablogsal

opened on Jul 2, 2022

Issue body actions

The code that sets trace and profile functions is not re-entrant. We are leaking objects if removing a profile/trace functions triggers a re-entrant call.

We should raise in this case.

Activity

1. pablogsal

   changed the title [-]sys.settrace is not re-entrant[/-] [+]sys.settrace and sys.setprofile are not re-entrant[/+] on Jul 2, 2022
2. pablogsal

   added a commit that references this issue on Jul 2, 2022

   pythongh-94510: Raise on re-entrant calls to sys.setprofile and sys.s…

   f93fd61
3. ambv

   added 2 commits that reference this issue on Jul 5, 2022

   gh-94510: Raise on re-entrant calls to sys.setprofile and sys.settrace (

   40d81fd

   [3.11] pythongh-94510: Raise on re-entrant calls to sys.setprofile an…

   812aa84
4. ambv

   added a commit that references this issue on Jul 5, 2022

   [3.10] pythongh-94510: Raise on re-entrant calls to sys.setprofile an…

   0e396d4
5. pablogsal

   added 2 commits that reference this issue on Jul 5, 2022

   [3.10] pythongh-94510: Raise on re-entrant calls to sys.setprofile an…

   2f6428c

   [3.10] gh-94510: Raise on re-entrant calls to sys.setprofile and syss…

   5e24c80
6. ambv

   added a commit that references this issue on Jul 5, 2022

   [3.11] gh-94510: Raise on re-entrant calls to sys.setprofile and sys.…

   5f4a16b
7. ambv commented on Jul 5, 2022

   

   ambv

   on Jul 5, 2022

   Contributor

   More actions

   This is now fixed in 3.10 - 3.12. Thanks, Pablo! ✨ 🍰 ✨
8. ambv

   closed this as completedon Jul 5, 2022
9. vstinner commented on Oct 14, 2022

   

   vstinner

   on Oct 14, 2022

   Member

   More actions

   This change introduce a randomly failure in test_import: issue #98257.

   I propose to make the function reentrant, rather than detecting and rejecting reentrant call: PR #98258.

Issue actions