Description

encukou

opened on Jul 11, 2022

Issue body actions

The test_cppext test case only checks that the C++ extension builds. It does not import and run test cases, so it can't catch runtime issues like #94731.

Reacted by Michael Droettboom

Activity

1. encukou

   added

   testsTests in the Lib/test dirTests in the Lib/test dir

   on Jul 11, 2022
2. encukou

   added a commit that references this issue on Jul 12, 2022

   gh-94751: Install, import and run the test C++ extension (MVP) (GH-94754

   ec5db53
3. miss-islington

   added a commit that references this issue on Jul 12, 2022

   pythongh-94751: Install, import and run the test C++ extension (MVP) (p…

   1ab009d
4. encukou commented on Jul 12, 2022

   

   encukou

   on Jul 12, 2022

   MemberAuthor

   More actions

   Merged the MVP, but there's still work to do:

   • running setup.py is deprecated, we should probably build/install using pip
   • the tests could be run individually, so the first failure doesn't mask others
5. encukou

   added a commit that references this issue on Jul 13, 2022

   gh-94751: Install, import and run the test C++ extension (MVP) (GH-94754

   ffbd6ae
6. vstinner commented on Aug 3, 2022

   

   vstinner

   on Aug 3, 2022

   Member

   More actions

   The test_cppext test case only checks that the C++ extension builds

   Right, for now it's its only purpose as written at top of Lib/test/_testcppext.cpp:

   // gh-91321: Very basic C++ test extension to check that the Python C API is
   // compatible with C++ and does not emit C++ compiler warnings.
   

   And Lib/test/test_cppext.py:

   # gh-91321: Build a basic C++ test extension to check that the Python C API is
   # compatible with C++ and does not emit C++ compiler warnings.
   

   The reason is that I was too lazy to finish the work to actually import the built extension. I got enough C++ issues to handle. By the way, it seems like most of the work to fix C++ warnings has been reverted by commit 6cbb57f.

   I also got busy with replacing distutils with setuptools (using venv).

Issue actions