GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||
GeezerVison is showing github.com — gh-72719: Remove deprecated `asyncore` and `asynchat` modules by sobolevn · Pull Request #96580 · python/cpython Conversation
| ||||||||||||||||||||||||
|
I think it would be great to have this PR merged before 3.12.0a1 (3 October, 2022, after 7 days) to allow third party library maintainers and early adopters to report scenarios possible in |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ping @pablogsal as release manager 🙂 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Thanks for checking with me! One note, the RM for 3.12 is @Yhg1s so he should probably also take a look |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 99e3de9 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Yhg1s Is there any chance to get this PR accepted into 3.12.0a1? It seems we've got some extra time until the release blockers are resolved. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
…pzF3.rst Co-authored-by: Jelle Zijlstra <[email protected]>
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
| @@ -0,0 +1,3 @@ | |||
| Remove modules :mod:`asyncore` and :mod:`asynchat`, which were deprecated by :pep:`594`. | |||
|
|
|||
| They are temporarily moved to :mod:`test.support` so some other tests that rely on them keep working. | |||
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I suggest to remove the second sentence. I prefer to hide them as well as possible :-)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Done, thank you for the review!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Please remove last references:
@giampaolo: Would you be ok to be removed from github/CODEOWNERS for asyncore/asynchat, so these files should not longer be updated but just die?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
When I removed the module last year (commit), I even renamed the asyncore module to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
sure, no problem |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Done, all three - removed! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Oh, there is now a conflict. Can you try to rebase your PR? Or try to merge main into your PR?
Please keep the license, files are still around, they are just moved somewhere else.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Merged, thanks. Let's see how it goes with Python 3.12. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thank you for your guidance and help! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
See also the discussion: Collaboration on handling Python 3.12 incompatible changes (distutils removal, invalid escape escape, etc.). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.