GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — `asyncore` and `asynchat` will be removed in 3.12 by sobolevn · Pull Request #9033 · python/typeshed

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 29, 2022

Copy link
Copy Markdown
Member

See python/cpython#96580

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
asyncore and asynchat will be removed in 3.12
65c3046
AlexWaygood
AlexWaygood previously requested changes Oct 29, 2022
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last version in the "version ranges" in this file is the "last version when the module was available" :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread stdlib/VERSIONS Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread stdlib/VERSIONS Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Oct 29, 2022

Copy link
Copy Markdown
Member

I'm also not sure if we should do this before the runtime PR's been merged? But don't have a strong opinion either way on that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn @AlexWaygood
Apply suggestions from code review
aff8dab 
Co-authored-by: Alex Waygood <[email protected]>
@AlexWaygood
AlexWaygood dismissed their stale review October 29, 2022 11:41

Changes made

@github-actions

This comment has been minimized.

Sign in to view
@hauntsaninja

hauntsaninja commented Oct 29, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

I think stubtest might not complain about missing stubs for stdlib modules, so this is best done when betas are released (in case the removal is undone)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Oct 29, 2022

Copy link
Copy Markdown
Member

I think stubtest might not complain about missing stubs for stdlib modules

That's correct, it doesn't
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added the status: deferred Issue or PR deferred until some precondition is fixed label Oct 29, 2022
@AlexWaygood
AlexWaygood marked this pull request as draft October 30, 2022 11:07
@AlexWaygood AlexWaygood changed the title asyncore and asynchat will be removed in 3.12 [Wait until 3.12 betas] asyncore and asynchat will be removed in 3.12 Oct 31, 2022
@sobolevn
Merge branch 'main' into asyncore-asynchat-removed
6391c39
@sobolevn sobolevn removed the status: deferred Issue or PR deferred until some precondition is fixed label May 23, 2023
@sobolevn
sobolevn marked this pull request as ready for review May 23, 2023 16:34
@sobolevn sobolevn changed the title [Wait until 3.12 betas] asyncore and asynchat will be removed in 3.12 asyncore and asynchat will be removed in 3.12 May 23, 2023
@sobolevn

sobolevn commented May 23, 2023

Copy link
Copy Markdown
Member Author

Beta 1 is out! 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood approved these changes May 23, 2023
View reviewed changes
@github-actions

github-actions Bot commented May 23, 2023

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srittau
srittau merged commit e666602 into python:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @AlexWaygood @hauntsaninja @srittau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.