GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — BINARY_SUBSCR_GETITEM has duplicate CALL_STAT_INC(inlined_py_calls) · Issue #96653 · python/cpython

BINARY_SUBSCR_GETITEM has duplicate CALL_STAT_INC(inlined_py_calls) #96653

New issue
Copy link
New issue
Copy link
Closed
Closed
BINARY_SUBSCR_GETITEM has duplicate CALL_STAT_INC(inlined_py_calls)#96653
Copy link
Assignees
markshannonFidget-Spinner
Labels
type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Description

@itamaro
itamaro
opened on Sep 7, 2022
Issue body actions

as titled and discussed in GH-92257

Activity

  1. itamaro
    added
    type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
    on Sep 7, 2022
  2. itamaro commented on Sep 7, 2022

    @itamaro
    itamaro
    on Sep 7, 2022
    ContributorAuthor
    More actions

    permalink -

    cpython/Python/ceval.c

    Lines 1662 to 1674 in 3eaf70d

    CALL_STAT_INC(inlined_py_calls);
    STACK_SHRINK(2);
    new_frame->localsplus[0] = container;
    new_frame->localsplus[1] = sub;
    for (int i = 2; i < code->co_nlocalsplus; i++) {
    new_frame->localsplus[i] = NULL;
    }
    _PyFrame_SetStackPointer(frame, stack_pointer);
    JUMPBY(INLINE_CACHE_ENTRIES_BINARY_SUBSCR);
    frame->prev_instr = next_instr - 1;
    new_frame->previous = frame;
    frame = cframe.current_frame = new_frame;
    CALL_STAT_INC(inlined_py_calls);

    @Fidget-Spinner I'm happy to submit a PR - not sure which one should be removed (or whether it matters)

  3. rhettinger
    assigned
    markshannon
    on Sep 7, 2022
  4. Fidget-Spinner commented on Sep 7, 2022

    @Fidget-Spinner
    Fidget-Spinner
    on Sep 7, 2022
    Member
    More actions

    It doesn't really matter, but I'd prefer we keep the one nearer to the bottom.

  5. Fidget-Spinner
    self-assigned this
    on Sep 7, 2022
  6. itamaro
    added a commit that references this issue on Sep 7, 2022

    pythongh-96653: Remove duplicate CALL_STAT_INC(inlined_py_calls) in B…

    d3d2dae
  7. Fidget-Spinner
    closed this as completedon Sep 8, 2022
  8. Fidget-Spinner
    added a commit that references this issue on Sep 8, 2022

    gh-96653: Remove duplicate CALL_STAT_INC(inlined_py_calls) in BINARY_…

    4f523a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

  • @Fidget-Spinner
    Fidget-Spinner
  • @markshannon
    markshannon

Labels

type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    You are visitor 01402503 — GeezerVison does not store the pages you look up.
    Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.