Description

ambv

opened on Sep 22, 2022

Issue body actions

Python 3.10 added NameError and AttributeError suggestions in raised exceptions, in the form of:

>>> dim
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'dim' is not defined. Did you mean: 'dir'?

This is implemented in Python/suggestions.c and unavailable in the pure Python implementation of traceback formatting in Lib/traceback.py. This makes the output of both different, which is problematic for tooling using traceback.py, as well as for alternative implementations of Python like PyPy and GraalPy.

Let's implement the equivalent of suggestions.c in Lib/traceback.py to bring both in line.

Activity

1. ambv

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   type-featureA feature request or enhancementA feature request or enhancement

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   and removed

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Sep 22, 2022
2. ambv commented on Sep 22, 2022

   

   ambv

   on Sep 22, 2022

   ContributorAuthor

   More actions

   cc @cfbolz
3. sweeneyde commented on Sep 22, 2022

   

   sweeneyde

   on Sep 22, 2022

   Member

   More actions

   I'm not sure if exact equivalence with suggestions.c is required, but if not, IIRC there was at one point a call to use difflib's get_close_matches(), which might simplify things.
4. ambv

   added a commit that references this issue on Sep 22, 2022

   pythongh-97008: Add a Python implementation of AttributeError and Nam…

   ef572ff
5. cfbolz commented on Sep 22, 2022

   

   cfbolz

   on Sep 22, 2022

   Contributor

   More actions

   @sweeneyde the plan is to start from PyPy's implementation, @ambv and I started working on that today (it's a port of Pablo's original commit, at the time I didn't your later changes hadn't landed).
6. gpshead commented on Sep 26, 2022

   

   gpshead

   on Sep 26, 2022

   Member

   More actions

   cc @Yhg1s
7. ambv

   added a commit that references this issue on Oct 4, 2022

   gh-97008: Add a Python implementation of AttributeError and NameError…

   bbc7cd6
8. ambv commented on Oct 4, 2022

   

   ambv

   on Oct 4, 2022

   ContributorAuthor

   More actions

   Fixed!
9. ambv

   closed this as completedon Oct 4, 2022
10. cfbolz commented on Oct 5, 2022

    

    cfbolz

    on Oct 5, 2022

    Contributor

    More actions

    wonderful, thank you @ambv, @pablogsal and @sweeneyde 😊
11. mpage

    added a commit that references this issue on Oct 11, 2022

    pythongh-97008: Add a Python implementation of AttributeError and Nam…

    c00e5c5

Issue actions