Description

kumaraditya303

opened on Oct 7, 2022

Issue body actions

PidfdChildWatcher based on pidfd_open is the best child watcher implementation for Linux as it avoids race conditions and is most reliable of all of them. It requires Linux 5.3+ so this will be detected at runtime if it can be used and if so use this instead of ThreadedChildWatcher. asyncio will favor using PidfdChildWatcher over ThreadedChildWatcher in 3.12+ on systems which supports it.

Activity

1. kumaraditya303

   added

   type-featureA feature request or enhancementA feature request or enhancement

   topic-asyncio

   3.12only security fixesonly security fixes

   on Oct 7, 2022
2. kumaraditya303

   added this to asyncioon Oct 7, 2022
3. kumaraditya303

   moved this to Todo in asyncioon Oct 7, 2022
4. kumaraditya303

   self-assigned this

   on Oct 7, 2022
5. gvanrossum

   added a commit that references this issue on Oct 8, 2022

   GH-98023: Change default child watcher to PidfdChildWatcher on suppor…

   8ba9378
6. gvanrossum commented on Oct 8, 2022

   

   gvanrossum

   on Oct 8, 2022

   Member

   More actions

   Thanks!

   There's a little bit of possible cleanup -- the check whether os.pidfd_open() exists and works (can_use_pidfd()) is duplicated in Lib/test/test_asyncio/test_subprocess.py (as _has_pidfd_support). While can_use_pidfd() is not a documented or public API I think it's better to call it from the test code so there's only one copy to update if the check ever changes.
7. gvanrossum

   closed this as completedon Oct 8, 2022
8. Repository owner moved this from Todo to Done in asyncioon Oct 8, 2022
9. carljm

   added 2 commits that reference this issue on Oct 8, 2022

   Merge branch 'main' into typewatch

   d67d6fd

   Merge branch 'main' into urllibnonet

   132c32e
10. mpage

    added a commit that references this issue on Oct 11, 2022

    pythonGH-98023: Change default child watcher to PidfdChildWatcher on …

    776f894

Issue actions