GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Consistent test failures in test test_asyncio.test_streams.test_drain_raises on Windows · Issue #98703 · python/cpython

Consistent test failures in test test_asyncio.test_streams.test_drain_raises on Windows #98703

New issue
Copy link
New issue
Copy link
Closed
Closed
Consistent test failures in test test_asyncio.test_streams.test_drain_raises on Windows#98703
Copy link
Assignees
Fidget-Spinner
Labels
3.10 (EOL)end of lifeend of life3.11only security fixesonly security fixes3.12only security fixesonly security fixestopic-asynciotype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Description

@Fidget-Spinner
Fidget-Spinner
opened on Oct 26, 2022
Issue body actions

Run python_d.exe -m test test_asyncio -m test_drain_raises -F on Windows. The test eventually fails after some repetitions.

The problem is that _call_connection_lost can be called multiple times, even after the socket by the proactortransport is closed. So it's calling close() on something that is already set to None.

I have a PR to fix it.

Activity

Next
  1. Fidget-Spinner
    added
    type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
    release-blocker
    on Oct 26, 2022
  2. ezio-melotti
    added this to Release and Deferred blockers 🚫on Oct 26, 2022
  3. ezio-melotti
    moved this to Todo in Release and Deferred blockers 🚫on Oct 26, 2022

  4. Fidget-Spinner commented on Oct 26, 2022

    @Fidget-Spinner
    Fidget-Spinner
    on Oct 26, 2022
    MemberAuthor
    More actions

    @pablogsal sorry to bother you right after the monumental 3.11 release (thanks for that by the way!). However, I'm setting this as release blocker as it's causing the Windows Buildbots to occasionally fail https://buildbot.python.org/all/#/builders/146.

    I have already created a PR to fix this.

    Reacted by Pablo Galindo Salgado
  5. Fidget-Spinner
    self-assigned this
    on Oct 26, 2022

  6. pablogsal commented on Oct 26, 2022

    @pablogsal
    pablogsal
    on Oct 26, 2022
    Member
    More actions

    Thanks a lot @Fidget-Spinner 🙏

    Reacted by Ken Jin
  7. kumaraditya303
    added
    topic-asyncio
    on Oct 26, 2022
  8. ezio-melotti
    added this to asyncioon Oct 26, 2022
  9. ezio-melotti
    moved this to Todo in asyncioon Oct 26, 2022
  10. kumaraditya303
    added
    3.12only security fixesonly security fixes
    on Oct 26, 2022
  11. Fidget-Spinner
    added
    3.11only security fixesonly security fixes
    on Oct 26, 2022
  12. Fidget-Spinner
    moved this from Todo to In Progress in Release and Deferred blockers 🚫on Oct 26, 2022
  13. kumaraditya303
    added
    3.10 (EOL)end of lifeend of life
    on Oct 26, 2022

  14. gvanrossum commented on Oct 26, 2022

    @gvanrossum
    gvanrossum
    on Oct 26, 2022
    Member
    More actions

    Does it needs to be a release blocker? Or just be backported?

  15. 5 remaining items

  16. miss-islington
    added a commit that references this issue on Oct 27, 2022

    gh-98703: Fix asyncio proactor_events calling _call_connection_lost m…

    08ce791
  17. Fidget-Spinner
    removed
    release-blocker
    on Oct 27, 2022
  18. Fidget-Spinner
    moved this from In Progress to Done in Release and Deferred blockers 🚫on Oct 27, 2022
  19. Fidget-Spinner
    moved this from Todo to Done in asyncioon Oct 27, 2022
  20. Fidget-Spinner
    moved this from Done to In Progress in asyncioon Oct 27, 2022

  21. Fidget-Spinner commented on Oct 27, 2022

    @Fidget-Spinner
    Fidget-Spinner
    on Oct 27, 2022
    MemberAuthor
    More actions

    Waiting for Kumar's tests to land before I close this issue. It's no longer a release blocker though.

  22. Fidget-Spinner
    added a commit that references this issue on Oct 27, 2022

    gh-98703: Add tests for closing `_ProactorSocketTransport` with proac…

    96ae80f
  23. miss-islington
    added 4 commits that reference this issue on Oct 27, 2022

    pythongh-98703: Add tests for closing `_ProactorSocketTransport` with…

    6869604

    pythongh-98703: Add tests for closing `_ProactorSocketTransport` with…

    0193292

    gh-98703: Add tests for closing `_ProactorSocketTransport` with proac…

    8e475ad

    gh-98703: Add tests for closing `_ProactorSocketTransport` with proac…

    9338e9a
  24. Fidget-Spinner
    closed this as completedon Oct 27, 2022
  25. Repository owner moved this from In Progress to Done in asyncioon Oct 27, 2022
  26. gvanrossum
    added 2 commits that reference this issue on Oct 28, 2022

    pythongh-98703: Fix asyncio proactor_events calling _call_connection_…

    f8d9bb5

    pythongh-98703: Add tests for closing `_ProactorSocketTransport` with…

    c66cd30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

  • @Fidget-Spinner
    Fidget-Spinner

Labels

3.10 (EOL)end of lifeend of life3.11only security fixesonly security fixes3.12only security fixesonly security fixestopic-asynciotype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Projects

  • Release and Deferred blockers 🚫
    Status
    Done
    Show more project fields
  • asyncio
    Status
    Done
    Show more project fields

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.