Description

sobolevn

opened on Nov 14, 2022

Issue body actions

There are several places where some Jython-specific hacks are used. For example, there are imports from com.python.core which is a third-party library.

They are untested and undocumented.

Right now Jython is stuck with 2.7
I think, we don't have to keep it: eventually Jython can patch it on their side, since all parts are pure-Python code.

Original issue on Jython's repo: jython/jython#217

I think we should leave this open for some time (1 month?) to let Jython's team to comment on this.

CC @Yhg1s

PR to review and comment is incoming :)

Linked PRs

• gh-99482: remove jython compatibility parts from stdlib and tests #99484

Activity

1. sobolevn

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Nov 14, 2022
2. vstinner commented on Nov 14, 2022

   

   vstinner

   on Nov 14, 2022

   Member

   More actions

   PyPy has patches on top of CPython stdlib. They fork the stdlib. I would prefer to avoid "downstream patches", but I don't recall any attempt from PyPy to merge these changes in CPython upstream.

   IMO it's ok if Jython also has "downstream patches" on top of CPython stdlib. I expect that they need a few changes to better integrate the stdlib with Jython, optimize the code, give access to Jython features, etc.

   Sadly yes, Jython seems inactive and I also would prefer to not continue maintaining code which is specific to Jython if nobody recalls where it comes from, if it's not tested, etc.
3. sobolevn

   self-assigned this

   on Nov 14, 2022
4. sobolevn commented on Nov 14, 2022

   

   sobolevn

   on Nov 14, 2022

   MemberAuthor

   More actions

   There's also https://docs.python.org/3/library/platform.html#java-platform
   But, I don't think we can touch it, since it is a public API: not specific to Jython. Others might use it as well.

   But, this can be deprecated after further usage analysis.
5. sobolevn

   added a commit that references this issue on Nov 14, 2022

   pythongh-99482: remove `jython` compatibility parts from stdlib and t…

   d4bf940
6. sobolevn commented on Nov 14, 2022

   

   sobolevn

   on Nov 14, 2022

   MemberAuthor

   More actions

   Citing Jython team:

   tl;dr: It's fine to remove from 3.x; I assume you have no interest in doing so from 2.7.

   Link: jython/jython#217 (comment)
7. hauntsaninja

   added a commit that references this issue on Dec 23, 2022

   gh-99482: remove `jython` compatibility parts from stdlib and tests (#…

   745545b
8. hauntsaninja

   closed this as completedon Dec 24, 2022
9. iritkatriel

   added a commit that references this issue on Dec 28, 2022

   Merged main into regmachine branch (#50)

   fdc73cb

Issue actions