GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-60203: Revert changes in cycle.__setstate__ (GH-99982) by ambv · Pull Request #100017 · python/cpython

Conversation

@ambv

@ambv ambv commented Dec 5, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In case if only True/False be supported as boolean arguments in future, we should continue to support 1/0 here.
(cherry picked from commit 922a6cf)

Co-authored-by: Serhiy Storchaka [email protected]

  • Issue: Using new 'bool' format character #60203

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka @ambv
[3.10] pythongh-60203: Revert changes in cycle.__setstate__ (pythonGH…
83b65cb
…-99982)

In case if only True/False be supported as boolean arguments in future,
we should continue to support 1/0 here.
(cherry picked from commit 922a6cf)

Co-authored-by: Serhiy Storchaka <[email protected]>
@ambv
ambv requested a review from rhettinger as a code owner December 5, 2022 16:32
This was referenced Dec 5, 2022
Using new 'bool' format character #60203
Closed
gh-60203: Revert changes in cycle.__setstate__ #99982
Merged
@bedevere-bot bedevere-bot added skip news awaiting core review labels Dec 5, 2022
@ambv
ambv merged commit b914eee into python:3.10 Dec 5, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Dec 5, 2022
@ambv
ambv deleted the backport-922a6cf-3.10 branch December 5, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ambv @bedevere-bot @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.