GeezerVison is showing github.com — gh-60203: Revert changes in cycle.__setstate__ by serhiy-storchaka · Pull Request #99982 · python/cpython
Conversation
serhiy-storchaka
commented
Dec 4, 2022
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
In case if only True/False be supported as boolean arguments in future, we should continue to support 1/0 here.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
In case if only True/False be supported as boolean arguments in future,
we should continue to support 1/0 here.
|
Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 922a6cf6c265e2763a003291885ff74d46203fc3 3.11
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Sorry @serhiy-storchaka and @ambv, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 922a6cf6c265e2763a003291885ff74d46203fc3 3.10
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
ambv
pushed a commit
to ambv/cpython
that referenced
this pull request
Dec 5, 2022
…-99982)
In case if only True/False be supported as boolean arguments in future,
we should continue to support 1/0 here.
(cherry picked from commit 922a6cf)
Co-authored-by: Serhiy Storchaka <[email protected]>
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
ambv
pushed a commit
to ambv/cpython
that referenced
this pull request
Dec 5, 2022
…-99982)
In case if only True/False be supported as boolean arguments in future,
we should continue to support 1/0 here.
(cherry picked from commit 922a6cf)
Co-authored-by: Serhiy Storchaka <[email protected]>
ambv
added a commit
that referenced
this pull request
Dec 5, 2022
…0017)
In case if only True/False be supported as boolean arguments in future,
we should continue to support 1/0 here.
(cherry picked from commit 922a6cf)
Co-authored-by: Serhiy Storchaka <[email protected]>
ambv
added a commit
that referenced
this pull request
Dec 5, 2022
…0016)
In case if only True/False be supported as boolean arguments in future,
we should continue to support 1/0 here.
(cherry picked from commit 922a6cf)
Co-authored-by: Serhiy Storchaka <[email protected]>
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️
Hi! The buildbot x86 Gentoo Installed with X 3.x has failed when building commit 922a6cf.
What do you need to do:
- Don't panic.
- Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
- Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/464/builds/3489) and take a look at the build logs.
- Check if the failure is related to this commit (922a6cf) or if it is a false positive.
- If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.
You can take a look at the buildbot page here:
https://buildbot.python.org/all/#builders/464/builds/3489
Failed tests:
Failed subtests:
- test_setpgroup - test.test_posix.TestPosixSpawnP.test_setpgroup
- test_setpgroup - test.test_posix.TestPosixSpawn.test_setpgroup
Summary of the results of the build (if available):
== Tests result: FAILURE then FAILURE ==
411 tests OK.
1 test failed:
test_posix
18 tests skipped:
test_asdl_parser test_check_c_globals test_clinic test_dbm_ndbm
test_devpoll test_gdb test_ioctl test_kqueue test_launcher
test_msilib test_peg_generator test_perf_profiler test_startfile
test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64
1 re-run test:
test_posix
Total duration: 53 min 17 sec
Click to see traceback logs
Traceback (most recent call last):
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.12/test/test_posix.py", line 1654, in test_setpgroup
setpgroup=os.getpgrp()
^^^^^^^^^^
AttributeError: module 'os' has no attribute 'getpgrp'. Did you mean: 'setpgrp'?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
gpshead
gpshead approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|