GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-81057: Move OS-Related Globals to _PyRuntimeState by ericsnowcurrently · Pull Request #100082 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Dec 7, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: [subinterpreters] Global C variables are a problem #81057

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently ericsnowcurrently added the skip news label Dec 7, 2022
@ericsnowcurrently
ericsnowcurrently requested a review from a team as a code owner December 7, 2022 17:15
@bedevere-bot bedevere-bot mentioned this pull request Dec 7, 2022
[subinterpreters] Global C variables are a problem #81057
Closed
@netlify

netlify Bot commented Dec 7, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

✅ Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit b8befdc
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/63925f7c5c9e170008558b26
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting core review label Dec 7, 2022
@ericsnowcurrently
ericsnowcurrently removed the request for review from a team December 7, 2022 17:17
ericsnowcurrently added 4 commits December 7, 2022 18:37
@ericsnowcurrently
Add _PyRuntimeState.os.
fe6e8d2
@ericsnowcurrently
Move dup3_works to the ignored list.
9a86dd3
@ericsnowcurrently
Move ticks_per_second to _PyRuntimeState.
7f6d5b8
@ericsnowcurrently
Eliminate structseq_new.
62179ba
@ericsnowcurrently
ericsnowcurrently force-pushed the consolidate-os-globals branch from 3f8e780 to 62179ba Compare December 8, 2022 17:12
ericsnowcurrently added 2 commits December 8, 2022 10:38
@ericsnowcurrently
Use subtests for test_stat_result_pickle.
d52f5dd
@ericsnowcurrently
Store the original tp_new in module state.
b8befdc
@ericsnowcurrently
ericsnowcurrently force-pushed the consolidate-os-globals branch from adc9260 to b8befdc Compare December 8, 2022 22:04
@ericsnowcurrently
ericsnowcurrently merged commit cda9f02 into python:main Dec 8, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Dec 8, 2022
@ericsnowcurrently
ericsnowcurrently deleted the consolidate-os-globals branch December 8, 2022 22:38
@vstinner

vstinner commented Dec 9, 2022

Copy link
Copy Markdown
Member

This change introduced a reference leak. Example with test_posixpath:

$ ./python -m test test_posixpath -R 3:3 -m test_ismount_directory_not_readable
(...)
test_posixpath leaked [9, 9, 9] references, sum=27
(...)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Dec 9, 2022

Copy link
Copy Markdown
Member

On PPC64LE Fedora Stable Refleaks 3.x, test_os and test_posixpath started to leak memory: https://buildbot.python.org/all/#builders/280/builds/548
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently

ericsnowcurrently commented Dec 9, 2022

Copy link
Copy Markdown
Member Author

I'll get that fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently ericsnowcurrently mentioned this pull request Dec 9, 2022
gh-81057: Fix a Reference Leak in the posix Module #100140
Merged
ericsnowcurrently added a commit that referenced this pull request Dec 9, 2022
@ericsnowcurrently
gh-81057: Fix a Reference Leak in the posix Module (gh-100140)
7a0f3c1 
The leak was introduced in gh-100082.

#81057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.