GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_ast uses infinite_recursion() to prevent crash by vstinner · Pull Request #100104 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Dec 8, 2022

Copy link
Copy Markdown
Member

test.test_ast_recursion_limit() now uses infinite_recursion() of test.support to prevent crashes on debug builds.

Before this change, the test crashed on ARM64 Windows 3.x buildbot worker which builds Python in debug mode.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
test_ast uses infinite_recursion() to prevent crash
2cf754d 
test.test_ast_recursion_limit() now uses infinite_recursion() of
test.support to prevent crashes on debug builds.

Before this change, the test crashed on ARM64 Windows 3.x buildbot
worker which builds Python in debug mode.
@vstinner vstinner added skip issue skip news labels Dec 8, 2022
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Dec 8, 2022
@netlify

netlify Bot commented Dec 8, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

✅ Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit 2cf754d
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/6391993cdfd72c00089b0f1a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the needs backport to 3.11 only security fixes label Dec 8, 2022
@vstinner vstinner mentioned this pull request Dec 8, 2022
gh-98724: Fix Py_CLEAR() macro side effects (#99100) #100070
Merged
@vstinner
vstinner merged commit cd67c1b into python:main Dec 8, 2022
@miss-islington

miss-islington commented Dec 8, 2022

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Dec 8, 2022
@vstinner
vstinner deleted the test_ast_recursive branch December 8, 2022 08:26
@bedevere-bot

bedevere-bot commented Dec 8, 2022

Copy link
Copy Markdown

GH-100105 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 8, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 8, 2022
@vstinner @miss-islington
test_ast uses infinite_recursion() to prevent crash (pythonGH-100104)
619c467 
test.test_ast_recursion_limit() now uses infinite_recursion() of
test.support to prevent crashes on debug builds.

Before this change, the test crashed on ARM64 Windows 3.x buildbot
worker which builds Python in debug mode.
(cherry picked from commit cd67c1b)

Co-authored-by: Victor Stinner <[email protected]>
miss-islington added a commit that referenced this pull request Dec 8, 2022
@miss-islington @vstinner
test_ast uses infinite_recursion() to prevent crash (GH-100104)
42fde2d 
test.test_ast_recursion_limit() now uses infinite_recursion() of
test.support to prevent crashes on debug builds.

Before this change, the test crashed on ARM64 Windows 3.x buildbot
worker which builds Python in debug mode.
(cherry picked from commit cd67c1b)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.