GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100176: Tools/iobench: Remove redundant compat code for Python <= 3.2 by hugovk · Pull Request #100197 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Dec 12, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Python 3.2 has been EOL since 2016-02-20 and 2.7 since 2020-01-01, so we can remove these old compatibility checks.

https://devguide.python.org/versions/

Also use f-strings and adjust some whitespace.

Ping also @pitrou who created this file with this note in 2010 in a69ba65:

This file should be kept compatible with both Python 2.6 and Python >= 3.0.

  • Issue: Meta issue: clean up redundant compat code #100176

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk hugovk added the skip news label Dec 12, 2022
@bedevere-bot bedevere-bot mentioned this pull request Dec 12, 2022
Meta issue: clean up redundant compat code #100176
Closed
@netlify

netlify Bot commented Dec 12, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

✅ Deploy Preview for python-cpython-preview ready!

Name Link
🔨 Latest commit 59f2f14
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/63972a48fa3a93000bfd01fb
😎 Deploy Preview https://deploy-preview-100197--python-cpython-preview.netlify.app/library/profile
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting core review label Dec 12, 2022
hugovk added 6 commits December 12, 2022 15:17
@hugovk
Remove compatibilty for Python < 3.3
21105fc
@hugovk
Remove compatibilty for Python 2
25663f3
@hugovk
Remove compatibilty note for Python 2.6 and 3.0-3.6
e1dadc2
@hugovk
Remove compatibilty for Python 2
1ee3e50
@hugovk
Whitespace between functions
902f9a2
@hugovk
Use f-strings
59f2f14
@hugovk
hugovk force-pushed the 100176-tools-iobench branch from b080903 to 59f2f14 Compare December 12, 2022 13:19
@hugovk

hugovk commented Jan 30, 2023

Copy link
Copy Markdown
Member Author

See https://discuss.python.org/t/do-we-still-need-tools-io-cc-string-bench/22557 for a discussion about Tools/{io,cc,string}bench, whether to leave, modernise, move or delete them.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood reviewed Jan 30, 2023
View reviewed changes
Comment thread Tools/iobench/iobench.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk @AlexWaygood
Use builtin % formatter
3936f0d 
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
AlexWaygood approved these changes Jan 30, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 30, 2023
@hugovk

hugovk commented Feb 12, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Let's hold off a bit merging this, we can remove the file instead:

  • Meta issue: clean up redundant compat code #100176 (comment)
  • https://discuss.python.org/t/do-we-still-need-tools-io-cc-string-bench/22557
  • gh-100176: Remove outdated Tools/{io,cc,string}bench #101853
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk mentioned this pull request Feb 12, 2023
gh-100176: Remove outdated Tools/{io,cc,string}bench #101853
Merged
@hugovk

hugovk commented Apr 8, 2023

Copy link
Copy Markdown
Member Author

Let's hold off a bit merging this, we can remove the file instead:

  • Meta issue: clean up redundant compat code #100176 (comment)
  • discuss.python.org/t/do-we-still-need-tools-io-cc-string-bench/22557
  • gh-100176: Remove outdated Tools/{io,cc,string}bench #101853

No decision there in a couple of months, let's merge this. We can still remove the file later.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk merged commit b22d021 into python:main Apr 8, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 8, 2023
@hugovk
hugovk deleted the 100176-tools-iobench branch April 8, 2023 09:05
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@hugovk @AlexWaygood @warsaw
pythongh-100176: Tools/iobench: Remove redundant compat code for Pyth…
4dd2c5a 
…on <= 3.2 (python#100197)

Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @AlexWaygood @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.