GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100305: Deemphasize that `ast.literal_eval` is safe in `eval` documentation by ramvikrams · Pull Request #100326 · python/cpython

Conversation

@ramvikrams

@ramvikrams ramvikrams commented Dec 17, 2022

Copy link
Copy Markdown
Contributor

gh-100305: Changed the doc referencing to literal_eval in eval as it was misleading as literal_eval was said safe

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ramvikrams
changed the doc for literal_eval in eval
45e57be
@bedevere-bot bedevere-bot mentioned this pull request Dec 17, 2022
ast.literal_eval is still referred to as safe by the documentation for eval #100305
Closed
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 17, 2022
ramvikrams added 2 commits December 18, 2022 03:36
@ramvikrams
Update functions.rst
c05387b
@ramvikrams
Update functions.rst
da1f416
slateny
slateny reviewed Dec 20, 2022
View reviewed changes
Comment thread Doc/library/functions.rst Outdated

See :func:`ast.literal_eval` for a function that can safely evaluate strings
with expressions containing only literals.
.. versionchanged:: 3.11

@slateny slateny Dec 20, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure about saying 'version changed', as it seems to imply that only 3.11 has the change, but 3.10 also has it as it was backported (see PR). I'd say it's okay to just keep the original format and adjust the wording.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ramvikrams ramvikrams Dec 20, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ramvikrams
Update functions.rst
d05eacc
@slateny
slateny requested a review from gpshead December 20, 2022 08:07
@slateny slateny changed the title gh-100305: ast.literal_eval is still referred to as safe by the documentation for eval gh-100305: Deemphasize that ast.literal_eval is safe in eval documentation Dec 20, 2022
merwok
merwok reviewed Nov 17, 2025
View reviewed changes
Comment thread Doc/library/functions.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Apr 12, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 12, 2026
@gpshead @merwok
don't scare quotes safely, just say to
e388fd4 
Co-authored-by: Éric <[email protected]>
gpshead
gpshead approved these changes Apr 12, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 12, 2026
@gpshead
gpshead enabled auto-merge (squash) April 12, 2026 03:00
@gpshead
Merge branch 'main' into t12
f6d3883
@gpshead gpshead added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Apr 12, 2026
@gpshead gpshead moved this from Todo to Done in Docs PRs Apr 12, 2026
@gpshead
gpshead merged commit b3b0cef into python:main Apr 12, 2026
34 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 12, 2026
@miss-islington-app

miss-islington-app Bot commented Apr 12, 2026

Copy link
Copy Markdown

Thanks @ramvikrams for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 12, 2026
@ramvikrams @merwok @miss-islington
pythongh-100305: Deemphasize that ast.literal_eval is safe in `eval…
e927748 
…` documentation (pythonGH-100326)

(cherry picked from commit b3b0cef)

Co-authored-by: Ram Vikram Singh <[email protected]>
Co-authored-by: Éric <[email protected]>
@bedevere-app

bedevere-app Bot commented Apr 12, 2026

Copy link
Copy Markdown

GH-148420 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 12, 2026
@ramvikrams @merwok @miss-islington
pythongh-100305: Deemphasize that ast.literal_eval is safe in `eval…
0f58608 
…` documentation (pythonGH-100326)

(cherry picked from commit b3b0cef)

Co-authored-by: Ram Vikram Singh <[email protected]>
Co-authored-by: Éric <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Apr 12, 2026
@bedevere-app

bedevere-app Bot commented Apr 12, 2026

Copy link
Copy Markdown

GH-148421 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Apr 12, 2026
StanFromIreland pushed a commit that referenced this pull request Apr 15, 2026
@miss-islington @ramvikrams @merwok
[3.13] gh-100305: Deemphasize that ast.literal_eval is safe in `eva…
9c2db81 
…l` documentation (GH-100326) (#148421)

(cherry picked from commit b3b0cef)

Co-authored-by: Ram Vikram Singh <[email protected]>
Co-authored-by: Éric <[email protected]>
StanFromIreland pushed a commit that referenced this pull request Apr 15, 2026
@miss-islington @ramvikrams @merwok
[3.14] gh-100305: Deemphasize that ast.literal_eval is safe in `eva…
0d2101d 
…l` documentation (GH-100326) (#148420)

(cherry picked from commit b3b0cef)

Co-authored-by: Ram Vikram Singh <[email protected]>
Co-authored-by: Éric <[email protected]>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@ramvikrams @merwok @ljfp
pythongh-100305: Deemphasize that ast.literal_eval is safe in `eval…
c5602a0 
…` documentation (python#100326)

Co-authored-by: Éric <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments
@slateny slateny slateny left review comments
@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ramvikrams @gpshead @merwok @slateny @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.