GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100340: Allows -Wno-int-conversion for wasm by kushaldas · Pull Request #100341 · python/cpython

Conversation

@kushaldas

@kushaldas kushaldas commented Dec 19, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Adds new configuration directive to disable int-conversion and then using it for the wasm32-wasi build only. This allows us to build on the version 17 of the wasm-sdk.

How to test manually?

Install the version 17 of the SDK and then run the following command:

./Tools/wasm/wasm_build.py wasi
  • Issue: Build failure on wasm-sdk-17 #100340

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot mentioned this pull request Dec 19, 2022
Build failure on wasm-sdk-17 #100340
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Dec 19, 2022
@kushaldas kushaldas added the skip news label Dec 19, 2022
@brettcannon brettcannon added the OS-wasi label Dec 19, 2022
@brettcannon
brettcannon requested review from brettcannon and tiran December 19, 2022 16:32
@brettcannon

brettcannon commented Dec 19, 2022

Copy link
Copy Markdown
Member

I looked at the output for https://buildbot.python.org/all/#/builders/1046 , but I couldn't find any way to tell what version of the WASI SDK was used to build Python. I know that @tiran set up the buildbots using https://github.com/tiran/ansible-wasm-buildbot .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushaldas

kushaldas commented Dec 19, 2022

Copy link
Copy Markdown
Member Author

I looked at the output for https://buildbot.python.org/all/#/builders/1046 , but I couldn't find any way to tell what version of the WASI SDK was used to build Python. I know that @tiran set up the buildbots using https://github.com/tiran/ansible-wasm-buildbot .

@brettcannon The buildbot is using version 16 according to https://github.com/tiran/ansible-wasm-buildbot/blob/main/roles/wasi-sdk/defaults/main.yml#L3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brettcannon
brettcannon reviewed Dec 19, 2022
View reviewed changes
Comment thread Tools/wasm/config.site-wasm32-wasi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/wasm/config.site-wasm32-wasi Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kushaldas
kushaldas force-pushed the wasi17_fix branch 2 times, most recently from 64a65f3 to 8fe9902 Compare December 20, 2022 08:34
@erlend-aasland
erlend-aasland self-requested a review December 20, 2022 19:07
erlend-aasland
erlend-aasland approved these changes Jan 11, 2023
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 11, 2023
@kushaldas
Fixes python#100340 allows -Wno-int-conversion for wasm
8da5d58
@kushaldas
kushaldas force-pushed the wasi17_fix branch from 8fe9902 to 8da5d58 Compare January 17, 2023 20:34
erlend-aasland
erlend-aasland approved these changes Jan 18, 2023
View reviewed changes
@kushaldas

kushaldas commented Jan 18, 2023

Copy link
Copy Markdown
Member Author

This worked on wasi-sdk-19 too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushaldas
kushaldas merged commit 75c8133 into python:main Jan 18, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 18, 2023
@brettcannon

brettcannon commented Mar 24, 2023

Copy link
Copy Markdown
Member

@kushaldas any reason this wasn't backported?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@merwok

merwok commented Jun 24, 2023

Copy link
Copy Markdown
Member

Came here from your recent blog post — as a small build change that can be considered a bug fix, and would give the benefit of keeping various python versions compatible with the latest wasi runtime, this seems fine to backport!
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@merwok merwok added the needs backport to 3.11 only security fixes label Jun 24, 2023
@miss-islington

miss-islington commented Jun 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @kushaldas for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2023
@kushaldas @miss-islington
pythongh-100340: Allows -Wno-int-conversion for wasm (pythonGH-100341)
1cd76ef 
Fixes pythonGH-100340 allows -Wno-int-conversion for wasm
(cherry picked from commit 75c8133)

Co-authored-by: Kushal Das <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 24, 2023

Copy link
Copy Markdown

GH-106066 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 24, 2023
erlend-aasland pushed a commit that referenced this pull request Jun 28, 2023
@miss-islington @kushaldas
[3.11] gh-100340: Allows -Wno-int-conversion for wasm (GH-100341) (#1…
966e0f6 
…06066)

(cherry picked from commit 75c8133)

Co-authored-by: Kushal Das <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon left review comments
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-wasi skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@kushaldas @brettcannon @merwok @miss-islington @bedevere-bot @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.