GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100458: Clarify Enum.__format__() change of mixed-in types in the whatsnew/3.11.rst by anze3db · Pull Request #100387 · python/cpython

gh-100458: Clarify Enum.__format__() change of mixed-in types in the whatsnew/3.11.rst #100387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethanfurman merged 7 commits into python:main from anze3db:main
May 1, 2023

Uh oh!

There was an error while loading. Please reload this page.
Merged

gh-100458: Clarify Enum.__format__() change of mixed-in types in the whatsnew/3.11.rst #100387

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e51f55c
Clarify Enum.__format__() change of mixed-in types
anze3db Dec 21, 2022
4ccc0fe
Point users to StrEnum or IntEnum for old formatting behavior
anze3db Dec 27, 2022
3311e3d
Merge branch 'main' into main
anze3db Dec 27, 2022
0d265a0
Split into multiple ines
anze3db Dec 27, 2022
5f30054
Fix small typo
anze3db Dec 27, 2022
bee67ca
Address PR feedback
anze3db Mar 22, 2023
6aed4ca
update prose
ethanfurman Apr 18, 2023
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view

There are no files selected for viewing

6 changes: 4 additions & 2 deletions 6 Doc/whatsnew/3.11.rst
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,10 +676,12 @@ enum
* Changed :meth:`Enum.__format__() <enum.Enum.__format__>`
(the default for :func:`format`, :meth:`str.format` and :term:`f-string`\s)
of enums with mixed-in types (e.g. :class:`int`, :class:`str`)
to also include the class name in the output, not just the member's key.
to include the class name and member key in the output, not the member's value.
Comment thread Outdated

@ethanfurman ethanfurman Feb 1, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to include the class name and member key in the output, not the member's value.
to show the class name and member name in the output, instead of the member's value.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anze3db reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
This matches the existing behavior of :meth:`enum.Enum.__str__`,
returning e.g. ``'AnEnum.MEMBER'`` for an enum ``AnEnum(str, Enum)``
Comment thread Outdated

@ethanfurman ethanfurman Feb 1, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
returning e.g. ``'AnEnum.MEMBER'`` for an enum ``AnEnum(str, Enum)``
returning e.g. ``'AnEnum.MEMBER'`` for an enum ``AnEnum(str, Enum)``.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anze3db reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
instead of just ``'MEMBER'``.
instead of the member's value. Those wishing to keep the old formatting behavior
Comment thread Outdated

@ethanfurman ethanfurman Feb 1, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
instead of the member's value. Those wishing to keep the old formatting behavior
Those wishing to keep the old formatting behavior

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anze3db reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
may wish to modify their enums with mixed-in types to inherit from the appropriate
:class:`StrEnum` or :class:`IntEnum` class.

* Added a new *boundary* class parameter to :class:`~enum.Flag` enums
and the :class:`~enum.FlagBoundary` enum with its options,
Expand Down
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.