GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100160: Restore and deprecate implicit creation of an event loop by serhiy-storchaka · Pull Request #100410 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Dec 21, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Partially revert changes made in GH-93453.

asyncio.DefaultEventLoopPolicy.get_event_loop() now emits a DeprecationWarning and creates and sets a new event loop instead of raising a RuntimeError if there is no current event loop set.

  • Issue: DeprecationWarning scope expanded in asyncio.events #100160

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-100160: Deprecate implicit creation of an event loop
8800552 
Partially revert changes made in pythonGH-93453.

asyncio.DefaultEventLoopPolicy.get_event_loop() now emits a
DeprecationWarning and creates and sets a new event loop instead of
raising a RuntimeError if there is no current event loop set.
@serhiy-storchaka
serhiy-storchaka requested review from 1st1, asvetlov, gvanrossum and kumaraditya303 as code owners December 21, 2022 15:58
@bedevere-bot bedevere-bot mentioned this pull request Dec 21, 2022
DeprecationWarning scope expanded in asyncio.events #100160
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Dec 21, 2022
@serhiy-storchaka
serhiy-storchaka requested a review from ambv December 21, 2022 15:59
@serhiy-storchaka
serhiy-storchaka marked this pull request as draft December 21, 2022 16:40
gvanrossum
gvanrossum reviewed Dec 21, 2022
View reviewed changes
Comment thread Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/asyncio-policy.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/asyncio/events.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/asyncio/events.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2022-12-21-17-49-50.gh-issue-100160.N0NHRj.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka and others added 4 commits December 22, 2022 09:30
@serhiy-storchaka @gvanrossum
Apply suggestions from code review
711efbf 
Co-authored-by: Guido van Rossum <[email protected]>
@serhiy-storchaka
Apply suggestions from the code review.
0feec4c
@serhiy-storchaka
Merge branch 'asyncio-get_event_loop3-3.12' of github.com:serhiy-stor…
0976177 
…chaka/cpython into asyncio-get_event_loop3-3.12
@serhiy-storchaka
Merge branch 'main' into asyncio-get_event_loop3-3.12
ee1242d
@serhiy-storchaka
serhiy-storchaka marked this pull request as ready for review December 22, 2022 07:37
@serhiy-storchaka serhiy-storchaka mentioned this pull request Dec 22, 2022
[3.11] gh-100160: Remove any deprecation warnings in asyncio.get_event_loop() #100412
Merged
gvanrossum
gvanrossum approved these changes Dec 23, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 23, 2022
@gvanrossum gvanrossum mentioned this pull request Jan 10, 2023
Finish deprecation in asyncio.get_event_loop() #93453
Closed
serhiy-storchaka added 2 commits January 12, 2023 11:40
@serhiy-storchaka
Tweak the documentation.
1e22c6f
@serhiy-storchaka
Merge branch 'main' into asyncio-get_event_loop3-3.12
cc34df5
@serhiy-storchaka serhiy-storchaka changed the title gh-100160: Deprecate implicit creation of an event loop gh-100160: Restore and deprecate implicit creation of an event loop Jan 12, 2023
@serhiy-storchaka
serhiy-storchaka merged commit e5bd5ad into python:main Jan 13, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 13, 2023
@serhiy-storchaka
serhiy-storchaka deleted the asyncio-get_event_loop3-3.12 branch January 13, 2023 12:40
@blink1073 blink1073 mentioned this pull request Oct 10, 2023
Add python 3.12 support jupyter/jupyter_core#367
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@ambv ambv Awaiting requested review from ambv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @gvanrossum @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.