GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.11] gh-100160: Remove any deprecation warnings in asyncio.get_event_loop() by serhiy-storchaka · Pull Request #100412 · python/cpython

Conversation

serhiy-storchaka commented Dec 21, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

They are deferred to Python 3.12.

Issue: DeprecationWarning scope expanded in asyncio.events #100160

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-100160: Remove any deprecation warnings in asyncio.get_event…

19c9a03

…_loop()

They are deferred to Python 3.12.

serhiy-storchaka added the needs backport to 3.10 label

Dec 21, 2022

serhiy-storchaka requested a review from ambv

December 21, 2022 16:38

bedevere-bot mentioned this pull request

Dec 21, 2022

DeprecationWarning scope expanded in asyncio.events #100160

Closed

bedevere-bot added the awaiting core review label

Dec 21, 2022

gvanrossum changed the title ~~gh-100160: Remove any deprecation warnings in asyncio.get_event_loop()~~ gh-100160: [3.11] Remove any deprecation warnings in asyncio.get_event_loop()

Dec 21, 2022

gvanrossum changed the title ~~gh-100160: [3.11] Remove any deprecation warnings in asyncio.get_event_loop()~~ [3.11] gh-100160: Remove any deprecation warnings in asyncio.get_event_loop()

Dec 21, 2022

gvanrossum reviewed

Dec 21, 2022

View reviewed changes

gvanrossum left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obv. this is a draft PR so this review is also a draft. :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added 2 commits

December 22, 2022 09:34


          Apply suggestions from the code review.

e930e8a


          Merge branch '3.11' into asyncio-get_event_loop3-3.11

c66da37

serhiy-storchaka marked this pull request as ready for review

December 22, 2022 07:37

serhiy-storchaka requested review from 1st1 and asvetlov as code owners

December 22, 2022 07:37


          Update docs.

e2a58b6

serhiy-storchaka commented Dec 22, 2022

Copy link

Copy Markdown

Member Author

Thank you for your review Guido. I switched it to draft to be sure that it will not be accidentally merged.

The hard part in these PRs (#100410 and #100412) is documentation. It is difficult to find good place where all this mess should be documented, and I am bad in writing English. I think that non-documentation part is ready, but I am not sure about the documentation. Fill free to commit directly to this branch or create a new PR based on it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pepoluan mentioned this pull request

Dec 29, 2022

Workaround for asyncio.get_event_loop() deprecation aio-libs/aiosmtpd#355

Merged

5 tasks done


          Merge branch '3.11' into asyncio-get_event_loop3-3.11

da16525

serhiy-storchaka mentioned this pull request

Jan 10, 2023

Finish deprecation in asyncio.get_event_loop() #93453

Closed

gvanrossum reviewed

Jan 10, 2023

View reviewed changes

gvanrossum left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here re a bunch of doc suggestions. I will merge those and then approve the PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/asyncio-policy.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/asyncio-policy.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/asyncio-policy.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Improve the doc notes a bit

5921a13

gvanrossum reviewed

Jan 10, 2023

View reviewed changes

gvanrossum left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more tense changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/asyncio-policy.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          More tense tweaks

e57283f

gvanrossum approved these changes

Jan 10, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

Jan 10, 2023


          Merge branch '3.11' into asyncio-get_event_loop3-3.11

bd86e99

gvanrossum merged commit 1b2459d into python:3.11

Jan 10, 2023

miss-islington commented Jan 10, 2023

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Jan 10, 2023

miss-islington commented Jan 10, 2023

Copy link

Copy Markdown

Contributor

Sorry, @serhiy-storchaka and @gvanrossum, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1b2459dc64b1c3eea89312ea9bf422f8d7c75bb2 3.10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington assigned gvanrossum

Jan 10, 2023

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Jan 12, 2023


          [3.10] [3.11] pythongh-100160: Remove any deprecation warnings in asy…

040373f

…ncio.get_event_loop() (pythonGH-100412)

Some deprecation warnings will reappear (in a slightly different form) in 3.12.

Co-authored-by: Guido van Rossum <[email protected]>.
(cherry picked from commit 1b2459d)

Co-authored-by: Serhiy Storchaka <[email protected]>

serhiy-storchaka mentioned this pull request

Jan 12, 2023

[3.10] [3.11] gh-100160: Remove any deprecation warnings in asyncio.g… #100970

Merged

bedevere-bot commented Jan 12, 2023

Copy link

Copy Markdown

GH-100970 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.10 label

Jan 12, 2023

serhiy-storchaka added a commit that referenced this pull request

Jan 13, 2023


          [3.10] gh-100160: Remove any deprecation warnings in asyncio.get_even…

87f9b1d

…t_loop() (GH-100412) (GH-100970)

Some deprecation warnings will reappear (in a slightly different form) in 3.12.

Co-authored-by: Guido van Rossum <[email protected]>.
(cherry picked from commit 1b2459d)

serhiy-storchaka deleted the asyncio-get_event_loop3-3.11 branch

January 13, 2023 07:35

hroncok mentioned this pull request

Jan 27, 2023

[3.8] Make the 3.10 related xfails non-strict aio-libs/aiohttp#7178

Merged

2 of 3 tasks

Reviewers

gvanrossum

gvanrossum approved these changes

ambv

Awaiting requested review from ambv

1st1

Awaiting requested review from 1st1

1st1 is a code owner

asvetlov

Awaiting requested review from asvetlov

asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

gvanrossum

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Dec 21, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

serhiy-storchaka commented Dec 22, 2022

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

miss-islington commented Jan 10, 2023

Uh oh!

miss-islington commented Jan 10, 2023

Uh oh!

bedevere-bot commented Jan 12, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

serhiy-storchaka commented Dec 21, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.