GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-100884: email/_header_value_parser: don't encode list separators by t-8ch · Pull Request #100885 · python/cpython

Conversation

@t-8ch

@t-8ch t-8ch commented Jan 9, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.

Fixes #100884

  • Issue: email: address list folding encodes list-separator comma #100884

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@t-8ch
pythonGH-100884: email/_header_value_parser: use existing ListSeparator
b1f41b8 
There already is already a predefined object with the correct
properties, use it.
@t-8ch
t-8ch requested a review from a team as a code owner January 9, 2023 13:55
@bedevere-bot bedevere-bot added the awaiting review label Jan 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 9, 2023
email: address list folding encodes list-separator comma #100884
Closed
@bedevere-bot

bedevere-bot commented Jan 9, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost

ghost commented Jan 9, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@t-8ch
pythonGH-100884: email/_header_value_parser: don't encode list separa…
75a89ca 
…tors

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.

Fixes python#100884
@t-8ch
t-8ch force-pushed the header-folding branch from 98ab61d to 75a89ca Compare January 9, 2023 14:08
@AlexWaygood AlexWaygood added the topic-email label Jan 9, 2023
@serhiy-storchaka
Merge branch 'main' into header-folding
f2c787a
serhiy-storchaka
serhiy-storchaka approved these changes Feb 17, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 17, 2024
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) February 17, 2024 09:56
@serhiy-storchaka
serhiy-storchaka disabled auto-merge February 17, 2024 09:56
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) February 17, 2024 09:57
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 17, 2024
@serhiy-storchaka
serhiy-storchaka merged commit 09fab93 into python:main Feb 17, 2024
@miss-islington-app

miss-islington-app Bot commented Feb 17, 2024

Copy link
Copy Markdown

Thanks @t-8ch for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 17, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 17, 2024
@t-8ch @miss-islington
pythongh-100884: email/_header_value_parser: don't encode list separa…
5f617f2 
…tors (pythonGH-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
(cherry picked from commit 09fab93)

Co-authored-by: Thomas Weißschuh <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 17, 2024

Copy link
Copy Markdown

GH-115592 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 17, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 17, 2024
@t-8ch @miss-islington
pythongh-100884: email/_header_value_parser: don't encode list separa…
a2640a5 
…tors (pythonGH-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
(cherry picked from commit 09fab93)

Co-authored-by: Thomas Weißschuh <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 17, 2024

Copy link
Copy Markdown

GH-115593 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Feb 17, 2024
serhiy-storchaka pushed a commit that referenced this pull request Feb 17, 2024
@miss-islington @t-8ch
[3.12] gh-100884: email/_header_value_parser: don't encode list separ…
9148b77 
…ators (GH-100885) (GH-115592)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
(cherry picked from commit 09fab93)

Co-authored-by: Thomas Weißschuh <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request Feb 17, 2024
@miss-islington @t-8ch
[3.11] gh-100884: email/_header_value_parser: don't encode list separ…
70754d2 
…ators (GH-100885) (GH-115593)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
(cherry picked from commit 09fab93)

Co-authored-by: Thomas Weißschuh <[email protected]>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@t-8ch @woodruffw
pythongh-100884: email/_header_value_parser: don't encode list separa…
90daba0 
…tors (pythonGH-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@t-8ch @diegorusso
pythongh-100884: email/_header_value_parser: don't encode list separa…
8b88128 
…tors (pythonGH-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
@mgmacias95 mgmacias95 mentioned this pull request May 6, 2024
Error parsing email headers: AttributeError: 'ValueTerminal' object has no attribute 'fold' #118643
Closed
@pablogsal

pablogsal commented May 10, 2024

Copy link
Copy Markdown
Member

@t-8ch @serhiy-storchaka can you take a look at #118643? Seems that this commit may have introduced a regression
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@t-8ch @LukasWoodtli
pythongh-100884: email/_header_value_parser: don't encode list separa…
f306be6 
…tors (pythonGH-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
@medmunds medmunds mentioned this pull request Feb 27, 2025
[3.10] gh-80222: Fix email address header folding with long quoted-string (GH-122753) #129111
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-email

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

email: address list folding encodes list-separator comma

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@t-8ch @bedevere-bot @pablogsal @serhiy-storchaka @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.