GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-90699: Clear interned strings in _elementtree by erlend-aasland · Pull Request #101185 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jan 20, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Interned strings were added in GH-99012

  • Issue: Replace _Py_IDENTIFIER() with statically initialized objects. #90699

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythonGH-90699: Clear interned strings in _elementtree
e487005 
Interned strings were added in pythonGH-99012
@erlend-aasland
erlend-aasland requested a review from kumaraditya303 January 20, 2023 09:17
@bedevere-bot bedevere-bot added the awaiting core review label Jan 20, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 20, 2023
Replace _Py_IDENTIFIER() with statically initialized objects. #90699
Closed
@erlend-aasland erlend-aasland added the skip news label Jan 20, 2023
kumaraditya303
kumaraditya303 approved these changes Jan 20, 2023
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 20, 2023
@kumaraditya303
kumaraditya303 merged commit 9109d46 into python:main Jan 20, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 20, 2023
@erlend-aasland
erlend-aasland deleted the etree/clear-strings branch January 20, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.