GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-90699: Remove `_Py_IDENTIFIER` usage from `_elementtree` module by kumaraditya303 · Pull Request #99012 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Nov 2, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Replace _Py_IDENTIFIER() with statically initialized objects. #90699

Automerge-Triggered-By: GH:ericsnowcurrently

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kumaraditya303
port etree
bb0b5ae
@bedevere-bot bedevere-bot mentioned this pull request Nov 2, 2022
Replace _Py_IDENTIFIER() with statically initialized objects. #90699
Closed
@bedevere-bot bedevere-bot added the awaiting review label Nov 2, 2022
@kumaraditya303 kumaraditya303 added the skip news label Nov 2, 2022
@kumaraditya303
kumaraditya303 requested a review from ericsnowcurrently November 2, 2022 16:38
ericsnowcurrently
ericsnowcurrently approved these changes Nov 2, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 2, 2022
@kumaraditya303

kumaraditya303 commented Nov 2, 2022

Copy link
Copy Markdown
Contributor Author

Merging main for #98988

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303 added 2 commits November 2, 2022 22:36
@kumaraditya303
Merge branch 'main' into etree
220a39f
@kumaraditya303
Merge branch 'main' into etree
5ec0056
@kumaraditya303

kumaraditya303 commented Nov 2, 2022

Copy link
Copy Markdown
Contributor Author

Okay so finally CI passed so good to merge.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kumaraditya303 kumaraditya303 assigned ericsnowcurrently Nov 2, 2022
@ericsnowcurrently ericsnowcurrently added the 🤖 automerge label Nov 2, 2022
@miss-islington
miss-islington merged commit 908e81f into python:main Nov 2, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 2, 2022
@ericsnowcurrently ericsnowcurrently removed their assignment Nov 2, 2022
@bedevere-bot

bedevere-bot commented Nov 2, 2022

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-emscripten node (pthreads) 3.x has failed when building commit 908e81f.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1050/builds/720) and take a look at the build logs.
  4. Check if the failure is related to this commit (908e81f) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1050/builds/720

Failed tests:

  • test_traceback

Failed subtests:

  • test_import_from_error_bad_suggestions_do_not_trigger_for_small_names - test.test_traceback.PurePythonSuggestionFormattingTests.test_import_from_error_bad_suggestions_do_not_trigger_for_small_names

Summary of the results of the build (if available):

== Tests result: FAILURE ==

341 tests OK.

10 slowest tests:

  • test_tokenize: 1 min 22 sec
  • test_unparse: 51.0 sec
  • test_lib2to3: 50.6 sec
  • test_io: 36.1 sec
  • test_capi: 35.5 sec
  • test_unicodedata: 26.3 sec
  • test_argparse: 22.9 sec
  • test_pickle: 22.5 sec
  • test_decimal: 20.4 sec
  • test_statistics: 18.2 sec

1 test failed:
test_traceback

95 tests skipped:
test__xxsubinterpreters test_asyncgen test_asynchat test_asyncio
test_asyncore test_check_c_globals test_clinic test_cmd_line
test_concurrent_futures test_contextlib_async test_ctypes
test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_doctest
test_docxmlrpc test_dtrace test_embed test_epoll test_faulthandler
test_fcntl test_file_eintr test_fork1 test_ftplib test_gdb
test_grp test_httplib test_httpservers test_idle test_imaplib
test_interpreters test_ioctl test_kqueue test_launcher test_lzma
test_mmap test_msilib test_multiprocessing_fork
test_multiprocessing_forkserver test_multiprocessing_main_handling
test_multiprocessing_spawn test_nis test_openpty test_ossaudiodev
test_pdb test_perf_profiler test_poll test_poplib test_pty
test_pwd test_readline test_regrtest test_repl test_resource
test_select test_selectors test_smtplib test_smtpnet test_socket
test_socketserver test_spwd test_ssl test_stable_abi_ctypes
test_startfile test_subprocess test_sys_settrace test_syslog
test_tcl test_telnetlib test_tix test_tkinter test_tools test_ttk
test_ttk_textonly test_turtle test_urllib2 test_urllib2_localnet
test_urllib2net test_urllibnet test_venv test_wait3 test_wait4
test_webbrowser test_winconsoleio test_winreg test_winsound
test_wmi test_wsgiref test_xmlrpc test_xmlrpc_net test_xxlimited
test_zipfile64 test_zipimport_support test_zoneinfo
0:23:37 load avg: 8.34
0:23:37 load avg: 8.34 Re-running failed tests is not supported with --python host runner option.

Total duration: 23 min 37 sec

Click to see traceback logs
TracebackFormatTests.test_exception_group_deep_recursion_traceback) ... ok


TracebackFormatTests.test_exception_group_deep_recursion_capi) ... ok


TracebackErrorCaretTests.test_caret_multiline_expression_bin_op) ... ok


TracebackErrorCaretTests.test_multiline_method_call_c) ... ok


TracebackErrorCaretTests.test_byte_offset_multiline) ... ok


TracebackCases.test_nocaret) ... ok


TracebackFormatTests.test_print_stack) ... ok


TracebackFormatTests.test_traceback_format_with_cleared_frames) ... ok


TracebackCases.test_clear) ... ok


TracebackCases.test_print_exception_exc) ... ok


TracebackException_ExceptionGroups.test_comparison) ... ok


TracebackErrorCaretTests.test_decorator_application_lineno_correct) ... ok


TracebackCases.test_base_exception) ... ok


TracebackCases.test_recursion_error_during_traceback) ... skipped 'requires subprocess support'


TracebackCases.test_encoded_file) ... skipped 'requires subprocess support'


TracebackException.test_lookup_lines) ... ok


TracebackErrorCaretTests.test_traceback_very_long_line) ... ok


TracebackErrorCaretTests.test_multiline_method_call_a) ... ok


TracebackException_ExceptionGroups.test_exception_group_format_exception_only) ... ok


TracebackFormatTests.test_print_exception_bad_type_python) ... ok


TracebackException.test_unhashable) ... ok


TracebackException.test_smoke) ... ok


TracebackCases.test_print_traceback_at_exit) ... skipped 'requires subprocess support'


TracebackException.test_compact_no_cause) ... ok


TracebackCases.test_format_exception_exc) ... ok


TracebackCases.test_print_exception) ... ok


TracebackException.test_from_exception) ... ok


TracebackException_ExceptionGroups.test_max_group_depth) ... ok


TracebackErrorCaretTests.test_line_with_unicode) ... ok


TracebackCases.test_extract_stack) ... ok


Traceback (most recent call last):
  File "/opt/buildbot/bcannon-wasm/3.x.bcannon-wasm.emscripten-node-pthreads/build/Lib/test/test_traceback.py", line 3139, in test_import_from_error_bad_suggestions_do_not_trigger_for_small_names
    self.assertNotIn("mom", actual)
AssertionError: 'mom' unexpectedly found in "ImportError: cannot import name 'b' from 'yeKfAfyAvlLqVTuN' (/tmp/tmpietmomml/yeKfAfyAvlLqVTuN.py)"


TracebackErrorCaretTests.test_traceback_specialization_with_syntax_error) ... ok


TracebackErrorCaretTests.test_caret_multiline_expression_syntax_error) ... ok


TracebackCases.test_format_exception_only_exc) ... ok


TracebackErrorCaretTests.test_caret_for_subscript) ... ok


TracebackException.test_cause) ... ok


TracebackErrorCaretTests.test_caret_for_binary_operators_two_char) ... ok


TracebackException.test_comparison_basic) ... ok


TracebackException.test_compact_with_cause) ... ok


TracebackException.test_no_refs_to_exception_and_traceback_objects) ... ok


TracebackException.test_print) ... ok


TracebackException_ExceptionGroups.test_exception_group_format) ... ok


TracebackCases.test_no_caret_with_no_debug_ranges_flag) ... skipped 'requires subprocess support'


TracebackException.test_context) ... ok


TracebackException.test_comparison_params_variations) ... ok


TracebackException.test_comparison_equivalent_exceptions_are_equal) ... ok


TracebackException_ExceptionGroups.test_max_group_width) ... ok


TracebackErrorCaretTests.test_byte_offset_with_wide_characters_middle) ... ok


TracebackErrorCaretTests.test_caret_exception_group) ... ok


TracebackException.test_no_locals) ... ok


TracebackCases.test_bad_indentation) ... ok


TracebackFormatTests.test_traceback_format) ... ok


TracebackErrorCaretTests.test_secondary_caret_not_elided) ... ok


TracebackErrorCaretTests.test_specialization_variations) ... ok


TracebackException.test_traceback_header) ... ok


TracebackErrorCaretTests.test_multiline_method_call_b) ... ok


TracebackFormatTests.test_print_exception_bad_type_capi) ... ok


TracebackCases.test_caret) ... ok


TracebackFormatTests.test_recursive_traceback_python) ... ok


TracebackException.test_limit) ... ok


TracebackErrorCaretTests.test_basic_caret) ... ok


TracebackErrorCaretTests.test_caret_multiline_expression) ... ok


TracebackFormatTests.test_format_stack) ... ok


TracebackErrorCaretTests.test_caret_for_binary_operators) ... ok


TracebackErrorCaretTests.test_caret_in_type_annotation) ... ok


TracebackException.test_long_context_chain) ... ok


TracebackErrorCaretTests.test_wide_characters_unicode_with_problematic_byte_offset) ... ok


TracebackCases.test_format_exception_only_bad__str__) ... ok


TracebackCases.test_exception_is_None) ... ok


TracebackException_ExceptionGroups.test_exception_group_construction) ... ok


TracebackCases.test_no_caret_with_no_debug_ranges_flag_python_traceback) ... skipped 'requires subprocess support'


TracebackCases.test_signatures) ... ok


TracebackFormatTests.test_recursive_traceback_cpython_internal) ... ok


TracebackFormatTests.test_stack_format) ... ok


TracebackFormatTests.test_unhashable) ... ok


TracebackException.test_locals) ... ok
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kumaraditya303
kumaraditya303 deleted the etree branch November 3, 2022 09:22
@erlend-aasland erlend-aasland mentioned this pull request Jan 20, 2023
GH-90699: Clear interned strings in _elementtree #101185
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jan 20, 2023
@erlend-aasland
pythonGH-90699: Clear interned strings in _elementtree
e487005
Interned strings were added in pythonGH-99012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@kumaraditya303 @bedevere-bot @ericsnowcurrently @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.