GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-88597: Rename uuid's new CLI args to be in line with uuidgen. by achhina · Pull Request #101248 · python/cpython

Conversation

@achhina

@achhina achhina commented Jan 22, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Follow-up patch in regards to the proposed changes mentioned here.

❯ ./python.exe -m uuid -h          
usage: uuid.py [-h] [-u {uuid1,uuid3,uuid4,uuid5}] [-n NAMESPACE] [-N NAME]

Generates a uuid using the selected uuid function.

options:
  -h, --help            show this help message and exit
  -u {uuid1,uuid3,uuid4,uuid5}, --uuid {uuid1,uuid3,uuid4,uuid5}
                        The function to use to generate the uuid. By default uuid4 function is used.
  -n NAMESPACE, --namespace NAMESPACE
                        The namespace is a UUID, or '@ns' where 'ns' is a well-known predefined UUID addressed by namespace name. Such as @dns,
                        @url, @oid, and @x500. Only required for uuid3/uuid5 functions.
  -N NAME, --name NAME  The name used as part of generating the uuid. Only required for uuid3/uuid5 functions.
  • Issue: Add command-line functionality to uuid module #88597

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@achhina
pythonGH-88597: Rename uuid cli args and parameters to be in line wit…
bad954e
…h uuidgen.
@bedevere-bot bedevere-bot added the awaiting review label Jan 22, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 22, 2023
Add command-line functionality to uuid module #88597
Closed
achhina
achhina commented Jan 22, 2023
View reviewed changes
Comment thread Doc/library/uuid.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@achhina

achhina commented Jan 22, 2023

Copy link
Copy Markdown
Contributor Author

Hi @gpshead, would you be able to take a look at this when you get a chance?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gpshead
updated a missed -n to -N change in the docs.
f271cc6
gpshead
gpshead approved these changes Jan 23, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 23, 2023
@gpshead
gpshead requested a review from serhiy-storchaka January 23, 2023 00:04
@gpshead

gpshead commented Jan 23, 2023

Copy link
Copy Markdown
Member

I think this looks good, I looped @serhiy-storchaka in to see if he's got any more suggestions.

achhina reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gpshead gpshead self-assigned this Jan 23, 2023
serhiy-storchaka
serhiy-storchaka approved these changes Jan 23, 2023
View reviewed changes
@gpshead gpshead added the skip news label Jan 23, 2023
@gpshead gpshead changed the title GH-88597: Rename uuid cli args and parameters to be in line with uuidgen. GH-88597: Rename uuid's new CLI args to be in line with uuidgen. Jan 23, 2023
@gpshead
gpshead merged commit 952a1d9 into python:main Jan 25, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 25, 2023
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Jan 25, 2023
@achhina @iritkatriel
pythonGH-88597: Rename uuid's new CLI args to be in line with uuidgen. (
97081c9
python#101248)

this way they match an existing uuidgen command line tool.
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
@achhina @mdboom
pythonGH-88597: Rename uuid's new CLI args to be in line with uuidgen. (
bf22554
python#101248)

this way they match an existing uuidgen command line tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@achhina @gpshead @serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.