GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101277: Isolate itertools, part 2/4 by erlend-aasland · Pull Request #101303 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jan 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add dropwhile, takewhile, starmap, combinations*, and permutations types to module state

  • Issue: Isolate the itertools extension module #101277

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
erlend-aasland requested a review from kumaraditya303 January 24, 2023 23:40
@bedevere-bot bedevere-bot added the awaiting core review label Jan 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 24, 2023
Isolate the itertools extension module #101277
Closed
@erlend-aasland erlend-aasland added the skip news label Jan 24, 2023
@erlend-aasland
erlend-aasland force-pushed the isolate-itertools/batch-2 branch from 8a063a7 to 2373926 Compare January 25, 2023 08:57
@erlend-aasland erlend-aasland mentioned this pull request Feb 1, 2023
gh-101277: Isolate itertools, add group and _grouper types to module state #101302
Merged
erlend-aasland added 7 commits February 1, 2023 12:52
@erlend-aasland
pythongh-101277: Add cycle type to module state
45e2e2b
@erlend-aasland
pythongh-101277: Add dropwhile type to module state
da07748
@erlend-aasland
pythongh-101277: Add takewhile type to module state
0f486ef
@erlend-aasland
pythongh-101277: Add starmap type to module state
af5fbe5
@erlend-aasland
pythongh-101277: Add combinations and cwr types to module state
7383a3d
@erlend-aasland
pythongh-101277: Add permutations type to module state
07d505e
@erlend-aasland
Fix cherry-picks; regen clinic
29a3485
@erlend-aasland
erlend-aasland force-pushed the isolate-itertools/batch-2 branch from 2373926 to 29a3485 Compare February 1, 2023 11:54
@erlend-aasland
erlend-aasland marked this pull request as ready for review February 1, 2023 11:56
@erlend-aasland
erlend-aasland requested a review from rhettinger as a code owner February 1, 2023 11:56
@corona10 corona10 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 1, 2023
@corona10
corona10 self-requested a review February 1, 2023 12:25
@bedevere-bot

bedevere-bot commented Feb 1, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 29a3485 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 1, 2023
corona10
corona10 approved these changes Feb 2, 2023
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 2, 2023
kumaraditya303
kumaraditya303 approved these changes Feb 3, 2023
View reviewed changes
@kumaraditya303
kumaraditya303 merged commit a52cc98 into python:main Feb 3, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 3, 2023
@kumaraditya303

kumaraditya303 commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland, onto the next one!
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Feb 3, 2023
@erlend-aasland @iritkatriel
pythongh-101277: Port more itertools static types to heap types (py…
fef6510 
…thon#101303)

Add dropwhile, takewhile, starmap, combinations*, and permutations types to module state.
@erlend-aasland

erlend-aasland commented Feb 3, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @erlend-aasland, onto the next one!

Thanks, Kumar! I'm on the road these days; I'll try to find the time to prepare part 3 later today.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland deleted the isolate-itertools/batch-2 branch February 3, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @bedevere-bot @kumaraditya303 @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.