GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98831: rewrite RAISE_VARARGS in the instruction definition DSL by iritkatriel · Pull Request #101306 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jan 25, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Generate the interpreter #98831

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-98831: rewrite RAISE_VARARGS in the instruction definition DSL
7fe1602
@iritkatriel
iritkatriel requested a review from gvanrossum January 25, 2023 00:01
@bedevere-bot bedevere-bot added the awaiting core review label Jan 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 25, 2023
Generate the interpreter #98831
Closed
@iritkatriel iritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jan 25, 2023
@bedevere-bot

bedevere-bot commented Jan 25, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 7fe1602 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 25, 2023
@iritkatriel
Merge branch 'main' into RAISE_VARARG
6d1e184
@iritkatriel
iritkatriel requested a review from markshannon January 25, 2023 15:51
iritkatriel
iritkatriel commented Jan 25, 2023
View reviewed changes
Comment thread Python/generated_cases.c.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum reviewed Jan 25, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Seems I forgot to send one comment.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/generated_cases.c.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
avoid emitting dead code
6071503
gvanrossum
gvanrossum approved these changes Jan 25, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 25, 2023
@iritkatriel
iritkatriel requested review from 1st1, asvetlov and kumaraditya303 as code owners January 25, 2023 21:18
@iritkatriel
apply Guido's suggestion
2daaa2e
gvanrossum
gvanrossum reviewed Jan 25, 2023
View reviewed changes
Comment thread Tools/cases_generator/test_generator.py
Comment on lines +346 to +347
PyObject *arg1 = PEEK(1);
PyObject *interim;

@gvanrossum gvanrossum Jan 25, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that if you run the tests it'll fail here. I accidentally hit return in the middle of this line and didn't re-run these tests before pushing. As these tests aren't run automatically yet this didn't trigger any CI failures. :-(

I'll fix it in my next change to this file, but I figured I'd warn you.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iritkatriel iritkatriel Jan 25, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I also made a mess of my branch just now. Will fix in a bit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iritkatriel iritkatriel Jan 25, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the makefile. Currently when I change the opcode_metadata.h file I need to touch compile.c. I had a look but wasn't sure what to change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gvanrossum
gvanrossum approved these changes Jan 25, 2023
View reviewed changes
iritkatriel added 2 commits January 25, 2023 21:23
@iritkatriel
Merge remote-tracking branch 'upstream/main' into RAISE_VARARG
d87d9af
@iritkatriel
regen
4df3e6b
@iritkatriel
iritkatriel force-pushed the RAISE_VARARG branch from d7c1c61 to 4df3e6b Compare January 25, 2023 21:32
@iritkatriel
avoid 'unused function' warnings
06ac7dd
@iritkatriel
iritkatriel merged commit b400219 into python:main Jan 25, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 25, 2023
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
@iritkatriel @mdboom
pythongh-98831: rewrite RAISE_VARARGS in the instruction definition D…
16695a0 
…SL (python#101306)
@iritkatriel
iritkatriel deleted the RAISE_VARARG branch April 3, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@1st1 1st1 Awaiting requested review from 1st1
@asvetlov asvetlov Awaiting requested review from asvetlov
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @bedevere-bot @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.