GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98831: Fix two bugs in case generator by gvanrossum · Pull Request #101349 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Jan 26, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • UndefinedLocalError when generating metadata for an 'op'
  • Accidental newline inserted in test_generator.py
  • Issue: Generate the interpreter #98831

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum
Fix two bugs in case generator
6a03438 
- UndefinedLocalError when generating metadata for an 'op'
- Accidental newline inserted in test_generator.py
@gvanrossum gvanrossum added the skip news label Jan 26, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jan 26, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 26, 2023
Generate the interpreter #98831
Closed
@gvanrossum
gvanrossum requested a review from iritkatriel January 26, 2023 16:47
iritkatriel
iritkatriel approved these changes Jan 26, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 26, 2023
@gvanrossum
gvanrossum marked this pull request as ready for review January 26, 2023 17:04
@gvanrossum
gvanrossum merged commit 9f2c479 into python:main Jan 26, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 26, 2023
@gvanrossum
gvanrossum deleted the fix-op-metadata branch January 26, 2023 17:18
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
@gvanrossum @mdboom
pythongh-98831: Fix two bugs in case generator (python#101349)
c682065 
Fix two bugs in case generator

- UndefinedLocalError when generating metadata for an 'op'
- Accidental newline inserted in test_generator.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gvanrossum @iritkatriel @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.