GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-100485: Add extended accuracy test. Switch to faster fma() based variant. by rhettinger · Pull Request #101383 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented Jan 28, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Consider adding sumproduct() or dotproduct() to the math module #100485

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rhettinger added 3 commits January 27, 2023 17:12
@rhettinger
FMA version
376df8a
@rhettinger
Neated-up
3f700be
@rhettinger
Compute TWO_PRODUCT() with FMA
43a7ba9
@rhettinger rhettinger added performance Performance or resource usage skip issue skip news labels Jan 28, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jan 28, 2023
@rhettinger
rhettinger marked this pull request as draft January 28, 2023 00:00
rhettinger added 2 commits January 27, 2023 18:05
@rhettinger
Remove default values from the test support functions
925235f
@rhettinger
Remove unused imports
16ea0db
@rhettinger rhettinger added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 28, 2023
@bedevere-bot

bedevere-bot commented Jan 28, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 43a7ba9 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 28, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 43a7ba9 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 28, 2023
rhettinger added 2 commits January 27, 2023 20:32
@rhettinger
Make tl_signature match argument order of the fma() in C
66bcff3
@rhettinger
Beautify comments
1e97b8a
@rhettinger rhettinger changed the title Experiment to check whether the faster fma() variant is reliable across platforms GH-100485: Add extended accuracy test. Switch to faster fma() based variant. Jan 28, 2023
@rhettinger rhettinger removed the skip issue label Jan 28, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 28, 2023
Consider adding sumproduct() or dotproduct() to the math module #100485
Closed
@rhettinger rhettinger added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 28, 2023
@bedevere-bot

bedevere-bot commented Jan 28, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 1e97b8a 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 28, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 1e97b8a 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 28, 2023
@rhettinger
rhettinger marked this pull request as ready for review January 28, 2023 02:47
@rhettinger
Merge branch 'main' into sumprod_fma
5355c47
@rhettinger rhettinger added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 28, 2023
@rhettinger rhettinger added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 28, 2023
@bedevere-bot

bedevere-bot commented Jan 28, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 5355c47 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 28, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 5355c47 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jan 28, 2023
@rhettinger rhettinger added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 28, 2023
@bedevere-bot

bedevere-bot commented Jan 28, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 5355c47 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 28, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 5355c47 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 28, 2023
@rhettinger
rhettinger merged commit 84483aa into python:main Jan 28, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 28, 2023
@rhettinger
rhettinger deleted the sumprod_fma branch January 28, 2023 12:29
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
@rhettinger @mdboom
pythonGH-100485: Add extended accuracy test. Switch to faster fma() b…
dc5314f 
…ased variant. pythonGH-101383)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

performance Performance or resource usage skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rhettinger @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.