GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-39615: fix warning on return type mismatch by iritkatriel · Pull Request #101407 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jan 29, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Should fix this:

image

  • Issue: Enhance frame handing in warnings.warn() to skip by module rather that stacklevel #39615

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@iritkatriel
pythongh-39615: fix warning on return type mismatch
6f13f4c
@iritkatriel
iritkatriel requested a review from gpshead January 29, 2023 21:38
@bedevere-bot bedevere-bot added the awaiting core review label Jan 29, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 29, 2023
Enhance frame handing in warnings.warn() to skip by module rather that stacklevel #39615
Closed
@iritkatriel iritkatriel added the skip news label Jan 29, 2023
gpshead
gpshead approved these changes Jan 30, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 30, 2023
@gpshead
gpshead merged commit c4170c3 into python:main Jan 30, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 30, 2023
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
@iritkatriel @mdboom
pythongh-39615: fix warning on return type mismatch (python#101407)
9f308a4
@iritkatriel
iritkatriel deleted the type-fix branch April 3, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @gpshead @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.