GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-77607: Improve accuracy of os.path.join docs (GH-101406) by miss-islington · Pull Request #101452 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 31, 2023

Copy link
Copy Markdown
Contributor

This is a follow-up to GH-100811.

One of the changes in that PR isn't accurate in that
os.path.join('', '') will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in GH-77607 and motivated the change
in GH-100811.
(cherry picked from commit 909a674)

Co-authored-by: Shantanu [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hauntsaninja @miss-islington
pythongh-77607: Improve accuracy of os.path.join docs (pythonGH-101406)
46a47ac
This is a follow-up to pythonGH-100811.

One of the changes in that PR isn't accurate in that
`os.path.join('', '')` will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in pythonGH-77607 and motivated the change
in pythonGH-100811.
(cherry picked from commit 909a674)

Co-authored-by: Shantanu <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Jan 31, 2023
This was referenced Jan 31, 2023
[doc] Behavior of os.path.join does not match documentation #77607
Closed
gh-77607: Improve accuracy of os.path.join docs #101406
Merged
@bedevere-bot bedevere-bot added skip news docs Documentation in the Doc dir labels Jan 31, 2023
hauntsaninja
hauntsaninja approved these changes Jan 31, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 31, 2023
@miss-islington
miss-islington merged commit f36c272 into python:3.10 Jan 31, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 31, 2023
@miss-islington
miss-islington deleted the backport-909a674-3.10 branch January 31, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @hauntsaninja @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.