GeezerVison

Copy link

Copy Markdown

Contributor

hauntsaninja requested review from JelleZijlstra and barneygale January 6, 2023 21:02

eryksun reviewed Jan 6, 2023

View reviewed changes

eryksun reviewed Jan 6, 2023

View reviewed changes

JelleZijlstra approved these changes Jan 7, 2023

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hauntsaninja commented Jan 7, 2023

View reviewed changes

eryksun reviewed Jan 8, 2023

View reviewed changes

hauntsaninja deleted the gh-100783 branch January 8, 2023 08:51

- Use "drive", not "drive letter", because of UNC paths
- Previous components are not thrown away from relative drive letters
- Use "segment" instead of "component" for consistency with pathlib
- Other miscellaneous improvements
(cherry picked from commit 53455a3)

Co-authored-by: Shantanu <[email protected]>

- Use "drive", not "drive letter", because of UNC paths
- Previous components are not thrown away from relative drive letters
- Use "segment" instead of "component" for consistency with pathlib
- Other miscellaneous improvements
(cherry picked from commit 53455a3)

Co-authored-by: Shantanu <[email protected]>

- Use "drive", not "drive letter", because of UNC paths
- Previous components are not thrown away from relative drive letters
- Use "segment" instead of "component" for consistency with pathlib
- Other miscellaneous improvements
(cherry picked from commit 53455a3)

Co-authored-by: Shantanu <[email protected]>

- Use "drive", not "drive letter", because of UNC paths
- Previous components are not thrown away from relative drive letters
- Use "segment" instead of "component" for consistency with pathlib
- Other miscellaneous improvements
(cherry picked from commit 53455a3)

Co-authored-by: Shantanu <[email protected]>

This is a follow-up to python#100811.

One of the changes in that PR isn't accurate in that
`os.path.join('', '')` will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in python#77607 and motivated the change
in python#100811.

This is a follow-up to #100811.

One of the changes in that PR isn't accurate in that
`os.path.join('', '')` will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in #77607 and motivated the change
in #100811.

This is a follow-up to pythonGH-100811.

One of the changes in that PR isn't accurate in that
`os.path.join('', '')` will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in pythonGH-77607 and motivated the change
in pythonGH-100811.
(cherry picked from commit 909a674)

Co-authored-by: Shantanu <[email protected]>

This is a follow-up to pythonGH-100811.

One of the changes in that PR isn't accurate in that
`os.path.join('', '')` will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in pythonGH-77607 and motivated the change
in pythonGH-100811.
(cherry picked from commit 909a674)

Co-authored-by: Shantanu <[email protected]>

This is a follow-up to GH-100811.

One of the changes in that PR isn't accurate in that
`os.path.join('', '')` will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in GH-77607 and motivated the change
in GH-100811.
(cherry picked from commit 909a674)

Co-authored-by: Shantanu <[email protected]>

This is a follow-up to GH-100811.

One of the changes in that PR isn't accurate in that
`os.path.join('', '')` will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in GH-77607 and motivated the change
in GH-100811.
(cherry picked from commit 909a674)

Co-authored-by: Shantanu <[email protected]>

This is a follow-up to python#100811.

One of the changes in that PR isn't accurate in that
`os.path.join('', '')` will not end in a separator.

This reverts that change to the previous wording that used "only", but
explicitly calls out the case where the last part ends in a separator,
which is what caused confusin in python#77607 and motivated the change
in python#100811.