GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-101440: fix json snippet error in logging-cookbook.rst (GH-101439) by miss-islington · Pull Request #101464 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 31, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 20c11f2)

Co-authored-by: Peter Jiping Xie [email protected]

  • Issue: extra comma (,) in the json snippet in Doc/howto/logging-cookbook.rst #101440

Automerge-Triggered-By: GH:hugovk

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@peterjpxie @miss-islington
pythongh-101440: fix json snippet error in logging-cookbook.rst (pyth…
17150be 
…onGH-101439)

(cherry picked from commit 20c11f2)

Co-authored-by: Peter Jiping Xie <[email protected]>
@miss-islington
miss-islington requested a review from vsajip as a code owner January 31, 2023 15:30
@bedevere-bot bedevere-bot added the awaiting review label Jan 31, 2023
This was referenced Jan 31, 2023
extra comma (,) in the json snippet in Doc/howto/logging-cookbook.rst #101440
Closed
gh-101440: fix json snippet error in logging-cookbook.rst #101439
Merged
@bedevere-bot bedevere-bot added skip news docs Documentation in the Doc dir labels Jan 31, 2023
hugovk
hugovk approved these changes Jan 31, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 31, 2023
@hugovk hugovk added the 🤖 automerge label Jan 31, 2023
@miss-islington
miss-islington merged commit 6b2ed1c into python:3.10 Jan 31, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 31, 2023
@miss-islington
miss-islington deleted the backport-20c11f2-3.10 branch January 31, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @hugovk @bedevere-bot @peterjpxie
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.