GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101440: fix json snippet error in logging-cookbook.rst by peterjpxie · Pull Request #101439 · python/cpython

Conversation

@peterjpxie

@peterjpxie peterjpxie commented Jan 30, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

remove the extra comma (,)

  • Issue: extra comma (,) in the json snippet in Doc/howto/logging-cookbook.rst #101440

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@peterjpxie
fix json snippet error in logging-cookbook.rst
d4d4561
@peterjpxie
peterjpxie requested a review from vsajip as a code owner January 30, 2023 22:32
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jan 30, 2023
@peterjpxie peterjpxie changed the title fix json snippet error in logging-cookbook.rst gh-101440: fix json snippet error in logging-cookbook.rst Jan 30, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 30, 2023
extra comma (,) in the json snippet in Doc/howto/logging-cookbook.rst #101440
Closed
rhettinger
rhettinger approved these changes Jan 30, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 30, 2023
@hugovk hugovk added needs backport to 3.10 needs backport to 3.11 only security fixes labels Jan 31, 2023
hugovk
hugovk approved these changes Jan 31, 2023
View reviewed changes
sobolevn
sobolevn approved these changes Jan 31, 2023
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not a valid JSON, trailing commas are not allowed (except for json5).

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
hugovk merged commit 20c11f2 into python:main Jan 31, 2023
@miss-islington

miss-islington commented Jan 31, 2023

Copy link
Copy Markdown
Contributor

Thanks @peterjpxie for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 31, 2023
@bedevere-bot

bedevere-bot commented Jan 31, 2023

Copy link
Copy Markdown

GH-101463 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 31, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2023
@peterjpxie @miss-islington
pythongh-101440: fix json snippet error in logging-cookbook.rst (pyth…
17150be 
…onGH-101439)

(cherry picked from commit 20c11f2)

Co-authored-by: Peter Jiping Xie <[email protected]>
@bedevere-bot

bedevere-bot commented Jan 31, 2023

Copy link
Copy Markdown

GH-101464 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jan 31, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2023
@peterjpxie @miss-islington
pythongh-101440: fix json snippet error in logging-cookbook.rst (pyth…
e3a6df6 
…onGH-101439)

(cherry picked from commit 20c11f2)

Co-authored-by: Peter Jiping Xie <[email protected]>
miss-islington added a commit that referenced this pull request Jan 31, 2023
@miss-islington @peterjpxie
gh-101440: fix json snippet error in logging-cookbook.rst (GH-101439)
6b2ed1c 
(cherry picked from commit 20c11f2)

Co-authored-by: Peter Jiping Xie <[email protected]>
miss-islington added a commit that referenced this pull request Jan 31, 2023
@miss-islington
[3.11] gh-101440: fix json snippet error in logging-cookbook.rst (GH-…
5e49807 
…101439) (GH-101463)

(cherry picked from commit 20c11f2)

Co-authored-by: Peter Jiping Xie <[email protected]>

Automerge-Triggered-By: GH:hugovk
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
@peterjpxie @mdboom
pythongh-101440: fix json snippet error in logging-cookbook.rst (pyth…
371a25e 
…on#101439)
carljm added a commit to carljm/cpython that referenced this pull request Jan 31, 2023
@carljm
Merge branch 'main' into inlinecomp2
ed3209b 
* main:
  pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439)
  pythongh-99276 - Updated Doc/faq/general.rst (python#101396)
  Add JOBS parameter to docs Makefile (python#101395)
  pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443)
  pythongh-77607: Improve accuracy of os.path.join docs (python#101406)
  Fixes typo in asyncio.TaskGroup context manager code example (python#101449)
  pythongh-98831: Clean up and add cache size static_assert to macro (python#101442)
  pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)
@peterjpxie
peterjpxie deleted the fix_json_error_in_logging-cookbook.rst branch March 25, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@rhettinger rhettinger rhettinger approved these changes
@sobolevn sobolevn sobolevn approved these changes
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@peterjpxie @miss-islington @bedevere-bot @hugovk @rhettinger @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.