GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-101266: Fix __sizeof__ for subclasses of int (GH-101394) by mdickinson · Pull Request #101579 · python/cpython

Conversation

@mdickinson

@mdickinson mdickinson commented Feb 5, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Manual backport of #101394 to the Python 3.11 branch

  • Issue: int and set subclass __sizeof__ under-reports the instance dictionary pointer #101266

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mdickinson added 5 commits February 5, 2023 11:49
@mdickinson
Fix __sizeof__ for subclasses of int
d77002e 
(cherry picked from commit c345b90)
@mdickinson
Fix markup
37a2ba5 
(cherry picked from commit d8c8f32)
@mdickinson
Preserve existing comment
c310017 
(cherry picked from commit f46ba55)
@mdickinson
Fix tp_basicsize and tp_itemsize for bool
72038d0 
(cherry picked from commit b7eba00)
@mdickinson
Fix missing include
09a9a71 
(cherry picked from commit 9cd5d01)
@bedevere-bot bedevere-bot added the awaiting core review label Feb 5, 2023
This was referenced Feb 5, 2023
int and set subclass __sizeof__ under-reports the instance dictionary pointer #101266
Closed
gh-101266: Fix __sizeof__ for subclasses of int #101394
Merged
@mdickinson
mdickinson merged commit cf89c16 into python:3.11 Feb 5, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Feb 5, 2023
@mdickinson

mdickinson commented Feb 7, 2023

Copy link
Copy Markdown
Member Author

This caused issues with NumPy / Cython. Reverting so that this doesn't affect the 3.11.2 release.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mdickinson added a commit to mdickinson/cpython that referenced this pull request Feb 7, 2023
@mdickinson
Revert "[3.11] pythongh-101266: Fix __sizeof__ for subclasses of int (p…
2c5ae16 
…ythonGH-101394) (python#101579)"

This reverts commit cf89c16.
@mdickinson mdickinson mentioned this pull request Feb 7, 2023
[3.11] gh-101266: Revert fix __sizeof__ for subclasses of int #101638
Merged
mdickinson added a commit that referenced this pull request Feb 7, 2023
@mdickinson
[3.11] gh-101266: Revert fix __sizeof__ for subclasses of int (#101638)
358b02d 
Revert "[3.11] gh-101266: Fix __sizeof__ for subclasses of int (GH-101394) (#101579)"

This reverts commit cf89c16.
@mdickinson
mdickinson deleted the fix-sizeof-for-int-subtypes-311 branch February 7, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mdickinson @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.