GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-35086: Fix tkinter docs A Simple Hello World Program by daniellovell · Pull Request #10160 · python/cpython

Conversation

@daniellovell

@daniellovell daniellovell commented Oct 28, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Application class does not hold onto the master Tk() instance as a class attribute. This is a good practice, and newcomers to tkinter would likely have trouble closing the window without this since root will almost never be in the global namespace.

https://bugs.python.org/issue35086

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daniellovell
bpo-35086: Fix tkinter docs A Simple Hello World Program
64edcc3 
Application class does not hold onto the master Tk() instance as a class attribute.
@the-knights-who-say-ni

the-knights-who-say-ni commented Oct 28, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Oct 28, 2018
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 28, 2018
@daniellovell

daniellovell commented Oct 28, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Not sure why it says my CLA is not signed - I submitted earlier today.
devguide says make take a day to register, so I'm assuming that's the issue.

Regarding no news entry: I did not feel this change was significant enough to be reflected in Doc/whatsnew
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Oct 29, 2018
tirkarthi
tirkarthi approved these changes Oct 30, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Oct 30, 2018
serhiy-storchaka
serhiy-storchaka approved these changes Oct 30, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 30, 2018
@serhiy-storchaka serhiy-storchaka added needs backport to 3.6 skip news labels Oct 30, 2018
@serhiy-storchaka
serhiy-storchaka merged commit a80af77 into python:master Oct 30, 2018
@miss-islington

miss-islington commented Oct 30, 2018

Copy link
Copy Markdown
Contributor

Thanks @NuclearLemon for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 30, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 30, 2018
@daniellovell @miss-islington
bpo-35086: Fix tkinter example "A Simple Hello World Program". (pytho…
fb3bf01 
…nGH-10160)

The root widget was accessed as a global variable in the Application's method.
(cherry picked from commit a80af77)

Co-authored-by: Daniel Lovell <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Oct 30, 2018
@bedevere-bot

bedevere-bot commented Oct 30, 2018

Copy link
Copy Markdown

GH-10241 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 30, 2018
@daniellovell @miss-islington
bpo-35086: Fix tkinter example "A Simple Hello World Program". (pytho…
460ebb0 
…nGH-10160)

The root widget was accessed as a global variable in the Application's method.
(cherry picked from commit a80af77)

Co-authored-by: Daniel Lovell <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Oct 30, 2018
@bedevere-bot

bedevere-bot commented Oct 30, 2018

Copy link
Copy Markdown

GH-10242 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 30, 2018

Copy link
Copy Markdown
Contributor

Sorry, @NuclearLemon and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a80af770870937271865b5e2b05a2cfe40b024b6 2.7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned serhiy-storchaka Oct 30, 2018
miss-islington added a commit that referenced this pull request Oct 30, 2018
@miss-islington @daniellovell
bpo-35086: Fix tkinter example "A Simple Hello World Program". (GH-10160
f51ef51 
)

The root widget was accessed as a global variable in the Application's method.
(cherry picked from commit a80af77)

Co-authored-by: Daniel Lovell <[email protected]>
miss-islington added a commit that referenced this pull request Oct 30, 2018
@miss-islington @daniellovell
bpo-35086: Fix tkinter example "A Simple Hello World Program". (GH-10160
c843a47 
)

The root widget was accessed as a global variable in the Application's method.
(cherry picked from commit a80af77)

Co-authored-by: Daniel Lovell <[email protected]>
@serhiy-storchaka serhiy-storchaka removed the needs backport to 2.7 label Oct 30, 2018
@serhiy-storchaka serhiy-storchaka removed their assignment Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@tirkarthi tirkarthi tirkarthi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@daniellovell @the-knights-who-say-ni @miss-islington @bedevere-bot @serhiy-storchaka @tirkarthi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.