GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101632: Add a RETURN_CONST instruction by penguin-wwy · Pull Request #101633 · python/cpython

Conversation

@penguin-wwy

@penguin-wwy penguin-wwy commented Feb 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Add return const instruction #101632

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
penguin-wwy added 3 commits February 7, 2023 11:19
@penguin-wwy
Add RETURN_CONST instruction
90ee148
@penguin-wwy
Fix unittest
332c6f0
@penguin-wwy
Add news
9d40472
@penguin-wwy
penguin-wwy requested review from iritkatriel and markshannon as code owners February 7, 2023 06:58
@bedevere-bot bedevere-bot added the awaiting review label Feb 7, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 7, 2023
Add return const instruction #101632
Closed
@iritkatriel

iritkatriel commented Feb 7, 2023

Copy link
Copy Markdown
Member

Do you see a difference in any benchmarks?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@penguin-wwy

penguin-wwy commented Feb 7, 2023

Copy link
Copy Markdown
Contributor Author

I am executing pyperformance, please wait :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@penguin-wwy

penguin-wwy commented Feb 7, 2023

Copy link
Copy Markdown
Contributor Author

@iritkatriel I update the pyperformance result in issue
#101632 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev arhadthedev added the performance Performance or resource usage label Feb 7, 2023
@penguin-wwy
Fix test error
f1deb5c
@penguin-wwy
penguin-wwy requested a review from brandtbucher as a code owner February 7, 2023 08:27
@iritkatriel

iritkatriel commented Feb 7, 2023

Copy link
Copy Markdown
Member

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

Thanks, I'll try to replicate on our benchmark machine.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented Feb 7, 2023

Copy link
Copy Markdown
Member

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

Thanks, I'll try to replicate on our benchmark machine.

Also came out 1% faster.

Results are here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@penguin-wwy

penguin-wwy commented Feb 7, 2023

Copy link
Copy Markdown
Contributor Author

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

Thanks, I'll try to replicate on our benchmark machine.

Also came out 1% faster.

Results are here.

Thanks. It turned out a little better than I expected.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Feb 7, 2023
@penguin-wwy
Fix test_code
a987bea
iritkatriel
iritkatriel reviewed Feb 7, 2023
View reviewed changes
Comment thread Lib/test/test_code.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel changed the title gh-101632: Add return const instruction gh-101632: Add a RETURN_CONST instruction Feb 7, 2023
iritkatriel
iritkatriel approved these changes Feb 7, 2023
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 7, 2023
@iritkatriel
Merge branch 'main' into add_return_none
afba682
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 7, 2023
@bedevere-bot

bedevere-bot commented Feb 7, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit afba682 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 7, 2023
@iritkatriel

iritkatriel commented Feb 7, 2023

Copy link
Copy Markdown
Member

The "s390x Fedora Refleaks PR" buildbot is broken (for a few months at least). All other test runs were successful.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit 753fc8a into python:main Feb 7, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 7, 2023
@hauntsaninja hauntsaninja mentioned this pull request Feb 15, 2023
Multi-line arguments in a function call crashes CPython #101928
Closed
@hugovk hugovk mentioned this pull request Sep 27, 2023
GH-109190: Copyedit 3.12 What's New: Bytecode #109821
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Mar 28, 2026
22 exception chain decomposition is not correct sahebbiswas/pycrefine#34
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@penguin-wwy @iritkatriel @bedevere-bot @arhadthedev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.