GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-109190: Copyedit 3.12 What's New: Bytecode by AA-Turner · Pull Request #109821 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Sep 25, 2023 •
edited by hugovk
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Mostly cribbed from @MatthieuDartiailh's list in Bytecode documentation issues for Python 3.12 #107457, save for not covering
    FOR_ITER's new behaviour; the changes to the POP_JUMP_IF_* family of instructions; and the
    YIELD_VALUE change
  • I also noticed that sys.monitoring wasn't covered in "improved modules", so I've added that as it's somewhat related
  • Issue: What's New in Python 3.12 (copyediting) #109190

📚 Documentation preview 📚: https://cpython-previews--109821.org.readthedocs.build/en/109821/whatsnew/3.12.html

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
New opcodes; sys.monitoring
0185210
@AA-Turner AA-Turner added the needs backport to 3.12 only security fixes label Sep 25, 2023
@AA-Turner
AA-Turner requested review from ambv, hugovk, iritkatriel and markshannon September 25, 2023 07:28
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 25, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 25, 2023
What's New in Python 3.12 (copyediting) #109190
Closed
@AA-Turner
syntax
a4c1d22
MatthieuDartiailh
MatthieuDartiailh reviewed Sep 25, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner added 2 commits September 25, 2023 08:51
@AA-Turner
CALL_INSTRINSIC_2
d755483
@AA-Turner
undocumented opcodes
d6384a2
hugovk
hugovk reviewed Sep 25, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
'intrinsic'
4bd178d
@AA-Turner
AA-Turner requested a review from hugovk September 27, 2023 14:05
hugovk
hugovk approved these changes Sep 27, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the INTRINSIC typo :)

Let's merge, we can update later if END_SEND is ever documented (via #107457).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 27, 2023
hugovk
hugovk reviewed Sep 27, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Outdated
* Add the :opcode:`LOAD_SUPER_ATTR` instruction. (Contributed by Carl Meyer and
Vladimir Matveev in :gh:`103497`.)

* Add the :opcode:`RETURN_CONST` instruction. (:gh:`101632`.)

@hugovk hugovk Sep 27, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add credit for issue #101632 / PR #101633?

Suggested change
* Add the :opcode:`RETURN_CONST` instruction. (:gh:`101632`.)
* Add the :opcode:`RETURN_CONST` instruction. (Contributed by penguin_wwy in :gh:`101632`.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@AA-Turner AA-Turner Sep 27, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@penguin-wwy please could we check how you'd like to be credited for this change? (I have a slight preference against using usernames in the documentation!)

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@penguin-wwy penguin-wwy Sep 28, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tanks, if possible, then just use Wenyang Wang.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@hugovk hugovk Sep 28, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Merge branch 'main' into docs/whatsnew/bytecode
6ddc852 
# Conflicts:
#	Doc/whatsnew/3.12.rst
hugovk
hugovk reviewed Sep 28, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
Add credit
c29a5bb
@hugovk
hugovk enabled auto-merge (squash) September 28, 2023 04:29
@hugovk
hugovk merged commit 526380e into python:main Sep 28, 2023
@miss-islington

miss-islington commented Sep 28, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 28, 2023
@miss-islington

miss-islington commented Sep 28, 2023

Copy link
Copy Markdown
Contributor

Sorry, @AA-Turner and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 526380e28644236bde9e41b949497ca1ee22653f 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned hugovk Sep 28, 2023
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Sep 28, 2023
@AA-Turner
[3.12] pythonGH-109190: Copyedit 3.12 What's New: Bytecode (pythonGH-…
f8cb762 
…109821)

Co-authored-by: Hugo van Kemenade <[email protected]>.
(cherry picked from commit 526380e)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 28, 2023

Copy link
Copy Markdown

GH-110047 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 28, 2023
Yhg1s pushed a commit that referenced this pull request Sep 28, 2023
@AA-Turner
[3.12] GH-109190: Copyedit 3.12 What's New: Bytecode (GH-109821) (#11…
335e3d5 
…0047)

.
(cherry picked from commit 526380e)
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 29, 2023
@AA-Turner @hugovk @csm10495
pythonGH-109190: Copyedit 3.12 What's New: Bytecode (python#109821)
39eda99 
Co-authored-by: Hugo van Kemenade <[email protected]>
@AA-Turner
AA-Turner deleted the docs/whatsnew/bytecode branch September 29, 2023 08:16
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AA-Turner @hugovk @Glyphack
pythonGH-109190: Copyedit 3.12 What's New: Bytecode (python#109821)
0668232 
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@ambv ambv Awaiting requested review from ambv
@iritkatriel iritkatriel Awaiting requested review from iritkatriel
@markshannon markshannon Awaiting requested review from markshannon
+2 more reviewers
@MatthieuDartiailh MatthieuDartiailh MatthieuDartiailh left review comments
@penguin-wwy penguin-wwy penguin-wwy left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@AA-Turner @miss-islington @hugovk @MatthieuDartiailh @penguin-wwy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.