GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-100933: Improve `check_element` helper in `test_xml_etree` (GH-100934) by miss-islington · Pull Request #101686 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 8, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Items checked by this test are always str and dict instances.
(cherry picked from commit eb49d32)

Co-authored-by: Nikita Sobolev [email protected]

  • Issue: Remove check_string and check_mapping from test_xml_etree #100933

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn @miss-islington
pythongh-100933: Improve check_element helper in test_xml_etree (p…
513ade4 
…ythonGH-100934)

Items checked by this test are always `str` and `dict` instances.
(cherry picked from commit eb49d32)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Feb 8, 2023
This was referenced Feb 8, 2023
Remove check_string and check_mapping from test_xml_etree #100933
Closed
gh-100933: Improve check_element helper in test_xml_etree #100934
Merged
@bedevere-bot bedevere-bot added skip news tests Tests in the Lib/test dir labels Feb 8, 2023
@ambv
ambv merged commit 5f0b819 into python:3.11 Feb 8, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Feb 8, 2023
@miss-islington
miss-islington deleted the backport-eb49d32-3.11 branch February 8, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @ambv @bedevere-bot @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.