GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — gh-100933: Improve `check_element` helper in `test_xml_etree` by sobolevn · Pull Request #100934 · python/cpython Conversation
|
| element_get_attrib(ElementObject* self) | |
| { | |
| /* return borrowed reference to attrib dictionary */ | |
| /* note: this function assumes that the extra section exists */ | |
| PyObject* res = self->extra->attrib; | |
| if (!res) { | |
| /* create missing dictionary */ | |
| res = self->extra->attrib = PyDict_New(); | |
| } | |
| return res; |
text: cpython/Modules/_elementtree.c
Lines 561 to 564 in a9f0144
| PyObject *tmp = list_join(res); | |
| if (!tmp) | |
| return NULL; | |
| self->text = tmp; |
tail: cpython/Modules/_elementtree.c
Lines 582 to 585 in a9f0144
| PyObject *tmp = list_join(res); | |
| if (!tmp) | |
| return NULL; | |
| self->tail = tmp; |
As you can see, there are no "custom" types that should be checked differently. isinstance is enough.
test_xml_etree_c is also affected by this change.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@ambv I've updated the description of this PR as we discussed. Can you please take a look now? 🙂 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-101686 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…ythonGH-100934) Items checked by this test are always `str` and `dict` instances. (cherry picked from commit eb49d32) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-101687 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…ythonGH-100934) Items checked by this test are always `str` and `dict` instances. (cherry picked from commit eb49d32) Co-authored-by: Nikita Sobolev <[email protected]>
…H-100934) (#101686) Items checked by this test are always `str` and `dict` instances. (cherry picked from commit eb49d32) Co-authored-by: Nikita Sobolev <[email protected]>
…H-100934) (#101687) Items checked by this test are always `str` and `dict` instances. (cherry picked from commit eb49d32) Co-authored-by: Nikita Sobolev <[email protected]>
* main: (82 commits) pythongh-101670: typo fix in PyImport_ExtendInittab() (python#101723) pythonGH-99293: Document that `Py_TPFLAGS_VALID_VERSION_TAG` shouldn't be used. (#pythonGH-101736) no-issue: Add Dong-hee Na as the cjkcodecs codeowner (pythongh-101731) pythongh-101678: Merge math_1_to_whatever() and math_1() (python#101730) pythongh-101678: refactor the math module to use special functions from c11 (pythonGH-101679) pythongh-85984: Remove legacy Lib/pty.py code. (python#92365) pythongh-98831: Use opcode metadata for stack_effect() (python#101704) pythongh-101283: Version was just released, so should be changed in 3.11.3 (pythonGH-101719) pythongh-101283: Fix use of unbound variable (pythonGH-101712) pythongh-101283: Improved fallback logic for subprocess with shell=True on Windows (pythonGH-101286) pythongh-101277: Port more itertools static types to heap types (python#101304) pythongh-98831: Modernize CALL and family (python#101508) pythonGH-101696: invalidate type version tag in `_PyStaticType_Dealloc` (python#101697) pythongh-100221: Fix creating dirs in `make sharedinstall` (pythonGH-100329) pythongh-101670: typo fix in PyImport_AppendInittab() (pythonGH-101672) pythongh-101196: Make isdir/isfile/exists faster on Windows (pythonGH-101324) pythongh-101614: Don't treat python3_d.dll as a Python DLL when checking extension modules for incompatibility (pythonGH-101615) pythongh-100933: Improve `check_element` helper in `test_xml_etree` (python#100934) pythonGH-101578: Normalize the current exception (pythonGH-101607) pythongh-47937: Note that Popen attributes are read-only (python#93070) ...
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.