GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-35089: Don't mention typing.io and typing.re by srittau · Pull Request #10173 · python/cpython

Conversation

@srittau

@srittau srittau commented Oct 28, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue35089

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@srittau
bpo-35089: Don't mention typing.io and typing.re
6179543
@srittau
srittau requested review from gvanrossum and ilevkivskyi as code owners October 28, 2018 12:04
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 28, 2018
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 28, 2018
@srittau srittau mentioned this pull request Oct 28, 2018
Prefer flat namespace over using typing.io and typing.re python/typing#589
Closed
gvanrossum
gvanrossum approved these changes Oct 28, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 28, 2018
@gvanrossum

gvanrossum commented Oct 28, 2018

Copy link
Copy Markdown
Member

I suggest you add a NEWS entry.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ilevkivskyi
ilevkivskyi reviewed Oct 28, 2018
View reviewed changes
Comment thread Doc/library/typing.rst
and ``BinaryIO``, deriving from ``IO[str]`` and ``IO[bytes]``,
respectively. These represent the types of I/O streams such as returned by
Generic type ``IO[AnyStr]`` and subclasses ``TextIO(IO[str])``
and ``BinaryIO(IO[bytes])``

@ilevkivskyi ilevkivskyi Oct 28, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually like the original formulation more. But this one is also fine.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@gvanrossum gvanrossum Oct 28, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "and its subclasses".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ilevkivskyi reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@srittau srittau Oct 28, 2018

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that "This defined" is now wrong, but when removing the verb you have to reformulate. I first ended up with:

The generic type IO[AnyStr] and subclasses TextIO and BinaryIO, deriving from IO[str] and IO[bytes], respectively, represent the types of I/O streams such as returned by open.

But I found this hard to understand.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ilevkivskyi ilevkivskyi Oct 28, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srittau You can also try splitting the sentence in two parts. Anyway, this is not very important.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
srittau added 2 commits October 28, 2018 16:51
@srittau
Add a NEWS entry
cfeda96
@srittau
Add 'its'
2fddd79
@ilevkivskyi ilevkivskyi added needs backport to 3.6 labels Oct 28, 2018
@ilevkivskyi
ilevkivskyi merged commit c8a8d6b into python:master Oct 28, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 28, 2018
@miss-islington

miss-islington commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

Thanks @srittau for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2018
@srittau @miss-islington
bpo-35089: Don't mention typing.io and typing.re (pythonGH-10173)
4cd5643 
https://bugs.python.org/issue35089
(cherry picked from commit c8a8d6b)

Co-authored-by: Sebastian Rittau <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Oct 28, 2018
@bedevere-bot

bedevere-bot commented Oct 28, 2018

Copy link
Copy Markdown

GH-10177 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 28, 2018

Copy link
Copy Markdown

GH-10178 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Oct 28, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2018
@srittau @miss-islington
bpo-35089: Don't mention typing.io and typing.re (pythonGH-10173)
db5cb2f 
https://bugs.python.org/issue35089
(cherry picked from commit c8a8d6b)

Co-authored-by: Sebastian Rittau <[email protected]>
miss-islington added a commit that referenced this pull request Oct 28, 2018
@miss-islington @srittau
bpo-35089: Don't mention typing.io and typing.re (GH-10173)
c516dc6 
https://bugs.python.org/issue35089
(cherry picked from commit c8a8d6b)

Co-authored-by: Sebastian Rittau <[email protected]>
miss-islington added a commit that referenced this pull request Oct 28, 2018
@miss-islington @srittau
bpo-35089: Don't mention typing.io and typing.re (GH-10173)
a36f04c 
https://bugs.python.org/issue35089
(cherry picked from commit c8a8d6b)

Co-authored-by: Sebastian Rittau <[email protected]>
@srittau
srittau deleted the typing-doc branch October 28, 2018 16:34
srittau added a commit to srittau/cpython that referenced this pull request May 13, 2021
@srittau
Remove mention of typing.io and typing.re again
65757ba 
They were originally removed in pythonGH-10173 per bpo-35089, but then
readded in pythonGH-21574. Cf. bpo-38291 for decision to remove.
@srittau srittau mentioned this pull request May 13, 2021
bpo-38291: Remove mention of typing.io and typing.re again #26113
Merged
gvanrossum pushed a commit that referenced this pull request Jun 14, 2021
@srittau
bpo-38291: Remove mention of typing.io and typing.re again (GH-26113)
8a76683 
They were originally removed in GH-10173 per bpo-35089, but then
readded in GH-21574. Cf. bpo-38291 for decision to remove.
@miss-islington miss-islington mentioned this pull request Jun 14, 2021
[3.10] bpo-38291: Remove mention of typing.io and typing.re again (GH-26113) #26720
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 14, 2021
@srittau @miss-islington
bpo-38291: Remove mention of typing.io and typing.re again (pythonGH-…
d2bfaa8 
…26113)

They were originally removed in pythonGH-10173 per bpo-35089, but then
readded in pythonGH-21574. Cf. bpo-38291 for decision to remove.
(cherry picked from commit 8a76683)

Co-authored-by: Sebastian Rittau <[email protected]>
@miss-islington miss-islington mentioned this pull request Jun 14, 2021
[3.9] bpo-38291: Remove mention of typing.io and typing.re again (GH-26113) #26721
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 14, 2021
@srittau @miss-islington
bpo-38291: Remove mention of typing.io and typing.re again (pythonGH-…
5301eba 
…26113)

They were originally removed in pythonGH-10173 per bpo-35089, but then
readded in pythonGH-21574. Cf. bpo-38291 for decision to remove.
(cherry picked from commit 8a76683)

Co-authored-by: Sebastian Rittau <[email protected]>
miss-islington added a commit that referenced this pull request Jun 14, 2021
@miss-islington @srittau
bpo-38291: Remove mention of typing.io and typing.re again (GH-26113)
fc310cb 
They were originally removed in GH-10173 per bpo-35089, but then
readded in GH-21574. Cf. bpo-38291 for decision to remove.
(cherry picked from commit 8a76683)

Co-authored-by: Sebastian Rittau <[email protected]>
miss-islington added a commit that referenced this pull request Jun 14, 2021
@miss-islington @srittau
bpo-38291: Remove mention of typing.io and typing.re again (GH-26113)
7f02195 
They were originally removed in GH-10173 per bpo-35089, but then
readded in GH-21574. Cf. bpo-38291 for decision to remove.
(cherry picked from commit 8a76683)

Co-authored-by: Sebastian Rittau <[email protected]>
jdevries3133 pushed a commit to jdevries3133/cpython that referenced this pull request Jun 19, 2021
@srittau @jdevries3133
bpo-38291: Remove mention of typing.io and typing.re again (pythonGH-…
6109bfa 
…26113)

They were originally removed in pythonGH-10173 per bpo-35089, but then
readded in pythonGH-21574. Cf. bpo-38291 for decision to remove.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@ilevkivskyi ilevkivskyi ilevkivskyi left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@srittau @gvanrossum @miss-islington @bedevere-bot @ilevkivskyi @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.