GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101821: Cover `ast.main` function by sobolevn · Pull Request #101822 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Feb 11, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Couple of comments on the implementation:

  • script_helper.run_python_until_end has @support.requires_subprocess() guard, so it is should be safe for envs where subprocess is not available
  • os_helper.temp_dir is also widely used for temp files, it even catches OSError and warns about it

So, this new cases should not add any test falkiness or new failures 🙂

  • Issue: ast.main is not covered #101821

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn sobolevn added the skip news label Feb 11, 2023
@sobolevn
sobolevn requested a review from isidentical February 11, 2023 10:13
@bedevere-bot bedevere-bot added the awaiting review label Feb 11, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 11, 2023
ast.main is not covered #101821
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Feb 11, 2023
@sobolevn

sobolevn commented Feb 11, 2023

Copy link
Copy Markdown
Member Author

Oh, \n is platform specific. Fixing!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
arhadthedev
arhadthedev reviewed Feb 11, 2023
View reviewed changes
Comment thread Lib/test/test_ast.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
pythongh-101821: Cover ast.main function
a5821a9
@sobolevn
sobolevn force-pushed the issue-101821 branch from 97969cf to a5821a9 Compare February 12, 2023 08:20
@sobolevn
sobolevn requested a review from hauntsaninja March 11, 2023 11:41
@sobolevn

sobolevn commented Mar 11, 2023

Copy link
Copy Markdown
Member Author

@hauntsaninja can you please take a look? :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hauntsaninja
hauntsaninja approved these changes Mar 11, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Weird that the default indentation is 3

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 11, 2023
@hauntsaninja hauntsaninja added needs backport to 3.10 needs backport to 3.11 only security fixes labels Mar 11, 2023
@hauntsaninja
hauntsaninja merged commit bb396ee into python:main Mar 11, 2023
@miss-islington

miss-islington commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 11, 2023
@miss-islington

miss-islington commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @hauntsaninja, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker bb396eece44036a71427e7766fbb8e0247373102 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned hauntsaninja Mar 11, 2023
@miss-islington

miss-islington commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Sorry @sobolevn and @hauntsaninja, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker bb396eece44036a71427e7766fbb8e0247373102 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hauntsaninja hauntsaninja removed needs backport to 3.10 needs backport to 3.11 only security fixes labels Mar 11, 2023
@hauntsaninja

hauntsaninja commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Thanks! Fine not to backport since there are already merge conflicts
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Mar 12, 2023
@sobolevn @iritkatriel
pythongh-101821: Test coverage for ast.main function (python#101822)
f955ac9
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@sobolevn @warsaw
pythongh-101821: Test coverage for ast.main function (python#101822)
76610db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev left review comments
@hauntsaninja hauntsaninja hauntsaninja approved these changes
@isidentical isidentical Awaiting requested review from isidentical

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hauntsaninja hauntsaninja

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sobolevn @miss-islington @hauntsaninja @arhadthedev @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.